public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] make harddisk options dialog modal
Date: Tue, 20 Jun 2023 11:34:31 +0200	[thread overview]
Message-ID: <20230620093431.73772-1-m.sandoval@proxmox.com> (raw)

Modal dialogs block the user from interacting with the main window.

We already do this with message dialogs so for consistency sake, we set
the harddisk options dialog as modal. Note that one can see weird
behaviors when interacting with the window behind the dialog in certain
scenarios.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/proxinstall b/proxinstall
index fe0239f..f32abd2 100755
--- a/proxinstall
+++ b/proxinstall
@@ -2291,6 +2291,8 @@ sub create_hdoption_view {
     my $dialog = Gtk3::Dialog->new();
 
     $dialog->set_title("Harddisk options");
+    $dialog->set_modal(1);
+    $dialog->set_transient_for($window);
 
     $dialog->add_button("_OK", 1);
 
-- 
2.39.2





                 reply	other threads:[~2023-06-20  9:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230620093431.73772-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal