public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 6/7] change margins in create_basic_grid
Date: Tue, 20 Jun 2023 11:16:09 +0200	[thread overview]
Message-ID: <20230620091610.68835-7-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20230620091610.68835-1-m.sandoval@proxmox.com>

Previously the grids were inserted in a succession of boxes each with
its own set of margins and spacing. We define the margins now
exclusively in the grid and account for previous values.

Note that we match the top and bottom margins of the 'Target Harddisk'
panel which does not need to use a grid.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/proxinstall b/proxinstall
index 29ed8dc..86922e2 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1484,10 +1484,10 @@ my $create_basic_grid = sub {
     $grid->set_row_spacing(10);
     $grid->set_hexpand(1);
 
-    $grid->set_margin_start(10);
+    $grid->set_margin_start(20);
     $grid->set_margin_end(20);
-    $grid->set_margin_top(5);
-    $grid->set_margin_bottom(5);
+    $grid->set_margin_top(10);
+    $grid->set_margin_bottom(10);
 
     return $grid;
 };
-- 
2.39.2





  parent reply	other threads:[~2023-06-20  9:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20  9:16 [pve-devel] [PATCH installer 0/7] use gtk grids when possible Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 1/7] move create_basic_grid subroutine definition up Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 2/7] use basic grid in the network panel Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 3/7] expand ip address Gtk3::Entry Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 4/7] use basic grid in password panel Maximiliano Sandoval
2023-06-20  9:16 ` [pve-devel] [PATCH installer 5/7] use basic grid in country/timezone panel Maximiliano Sandoval
2023-06-20  9:16 ` Maximiliano Sandoval [this message]
2023-06-20  9:16 ` [pve-devel] [PATCH installer 7/7] remove trailing spaces and colons from labels Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230620091610.68835-7-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal