From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH] smartmontools.default: add `-q never` to smartd_opts
Date: Fri, 16 Jun 2023 14:22:08 +0200 [thread overview]
Message-ID: <20230616122208.3946516-1-s.ivanov@proxmox.com> (raw)
smartmontools has the option to run as 'notify' type systemd.service
(see `smartd(8)` in bookworm and later), and debian-upstream uses
this.
If a system has no monitorable disks (observed in a HP DL380g8, where
smartd does not seem to work by default with the the smart-array
controller with a RAID1 configured) the smartmontools.service fails
because smartd exits with 17.
Adding `-q nodev0`, which should cause the exit not to be considered a
failure does not work either, because type=notify does not expect the
daemon to exit (or the daemon exits before notifying systemd)
Tested by installing a version with this patch on the HP DL380g8
mentioned above, additionally inside a VM running PVE and a workstation
upgraded to the latest 8.0 beta.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
debian/smartmontools.default | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/smartmontools.default b/debian/smartmontools.default
index 6a8a6e2..ed6c78a 100644
--- a/debian/smartmontools.default
+++ b/debian/smartmontools.default
@@ -5,5 +5,5 @@
# Not needed (and not recommended) if the device is monitored by smartd
#enable_smart="/dev/hda /dev/hdb"
-# uncomment to pass additional options to smartd on startup
-#smartd_opts="--interval=1800"
+# to pass additional options to smartd on startup add them space separated
+smartd_opts="-q never"
--
2.30.2
next reply other threads:[~2023-06-16 12:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 12:22 Stoiko Ivanov [this message]
2023-06-16 14:53 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616122208.3946516-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox