public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Noel Ullreich <n.ullreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager 0/2] ui: fix #3760: change units of ram/swap
Date: Fri, 16 Jun 2023 11:54:08 +0200	[thread overview]
Message-ID: <20230616095410.33426-1-n.ullreich@proxmox.com> (raw)

Up until now, ram, balloonsize and swap were set in MiB, meaning if you wanted to
create or change a VMs/CTs memory, you would first have to do the math to
convert from GiB to MiB.
This patch adds a dropdown-menu of units, MiB, GiB, and TiB, (although
PiB could easily be added in the future) for ram and swap.
A future patch in line with this could add units in the API, allowing for
improved usability from the commandline (e.g. `qm create <id> --memory 2GiB`).

having `scalingFactor` list in MemoryEdit and Resource Edits might not
be the most elegant solution, the other option was sticking them in
`proxmox-widget-toolkit/src/Utils.js` or using the units from there.
However, if we want to use the units from there, we need to scale them
and trim the unneeded units. So I thought the least invasive solution
was to put the `scalingFactor` right in the Files.

Noel Ullreich (2):
  ui: fix #3760: change unit of memory of a VM
  ui: fix: change units of memory/swap for containers

 www/manager6/lxc/ResourceEdit.js | 136 ++++++++++++++++---
 www/manager6/qemu/MemoryEdit.js  | 221 +++++++++++++++++++++++--------
 2 files changed, 285 insertions(+), 72 deletions(-)

-- 
2.30.2





             reply	other threads:[~2023-06-16  9:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  9:54 Noel Ullreich [this message]
2023-06-16  9:54 ` [pve-devel] [PATCH pve-manager 1/2] ui: fix #3760: change unit of memory of a VM Noel Ullreich
2023-06-16  9:54 ` [pve-devel] [PATCH pve-manager 2/2] ui: fix: change units of memory/swap for containers Noel Ullreich
2023-07-03 12:08 ` [pve-devel] [PATCH pve-manager 0/2] ui: fix #3760: change units of ram/swap Noel Ullreich
2023-07-07 12:29 ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230616095410.33426-1-n.ullreich@proxmox.com \
    --to=n.ullreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal