From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-backup 3/3] file-restore: set loglevel considering PBS_QEMU_DEBUG
Date: Thu, 15 Jun 2023 12:42:57 +0200 [thread overview]
Message-ID: <20230615104257.3387232-4-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20230615104257.3387232-1-s.ivanov@proxmox.com>
during some tests recently I wondered why a debug log-message was not
printed, despite running with PBS_QEMU_DEBUG.
This patch sets the loglevel for the cli logger to debug if the
variable is present and not-empty (see qemu_helper.rs for the other
usage).
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
proxmox-file-restore/src/main.rs | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/proxmox-file-restore/src/main.rs b/proxmox-file-restore/src/main.rs
index 87caadc4..74ef1979 100644
--- a/proxmox-file-restore/src/main.rs
+++ b/proxmox-file-restore/src/main.rs
@@ -585,7 +585,12 @@ where
}
fn main() {
- init_cli_logger("PBS_LOG", "info");
+ let loglevel = match std::env::var("PBS_QEMU_DEBUG") {
+ Ok(val) if !val.is_empty() => "debug",
+ _ => "info"
+ };
+
+ init_cli_logger("PBS_LOG", loglevel);
let list_cmd_def = CliCommand::new(&API_METHOD_LIST)
.arg_param(&["snapshot", "path"])
--
2.30.2
next prev parent reply other threads:[~2023-06-15 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 10:42 [pve-devel] [PATCH proxmox-backup 0/3] file-restore: set arc limits correctly Stoiko Ivanov
2023-06-15 10:42 ` [pve-devel] [PATCH proxmox-backup 1/3] file-restore: add zfs. prefix to arc_min/max settings Stoiko Ivanov
2023-06-15 10:42 ` [pve-devel] [PATCH proxmox-backup 2/3] file-restore: set zfs_arc_min to current minimum of 32M Stoiko Ivanov
2023-06-15 10:42 ` Stoiko Ivanov [this message]
2023-06-15 16:11 ` [pve-devel] applied: [PATCH proxmox-backup 0/3] file-restore: set arc limits correctly Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615104257.3387232-4-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox