From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard
Date: Thu, 15 Jun 2023 10:08:15 +0200 [thread overview]
Message-ID: <20230615080815.921858-1-d.csapak@proxmox.com> (raw)
this field has a fixed height, which is too tall for the create wizard,
and one cannot see the last entry when scrolling all the way down.
to fix this, make it 20px shorter
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
alternatively we could also increase the height in the create wizard
the optimal solution would be to improve the layouting in our
wizard/inputpanel altogether so that it automatically gets the right
height, but that is a non-trivial rework there. imho this should work
fine as a stopgap fix for now
(feel free to put above comment into the commit message if it seems
appropriate)
www/manager6/form/VMCPUFlagSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
index ace3c531..03a119ab 100644
--- a/www/manager6/form/VMCPUFlagSelector.js
+++ b/www/manager6/form/VMCPUFlagSelector.js
@@ -12,7 +12,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
hideHeaders: true,
scrollable: 'y',
- height: 200,
+ height: 180,
unkownFlags: [],
--
2.30.2
next reply other threads:[~2023-06-15 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 8:08 Dominik Csapak [this message]
2023-06-15 8:10 ` Dominik Csapak
2023-11-06 16:31 ` Thomas Lamprecht
2023-11-07 7:50 ` Dominik Csapak
2023-11-07 7:56 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615080815.921858-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox