From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container v2 0/2] add test for LXC_NAME hosts entry and fix a minor glitch
Date: Wed, 14 Jun 2023 14:33:23 +0200 [thread overview]
Message-ID: <20230614123325.4122277-1-s.ivanov@proxmox.com> (raw)
v1->v2:
* actually added the /etc/hosts from an alpine template (seems I
fat-fingered a cp iniially) for patch 2 - sorry for the fuzz
original cover-letter for v1:
the patch from:
https://lists.proxmox.com/pipermail/pve-devel/2023-June/057420.html
broke the setup for templates which don't contain /etc/hosts.
This was fixed in a follow-up by Thomas.
Sorry for not noticing the broken tests (they are currently skipped if
building with sbuild, which I used)!
patch 2 adds an explicit test for the functionality in the patch
While checking the output I noticed a small glitch with Test::MockModule
in the snapshot-test.pm - which should be addressed with patch 1 of this
series.
Stoiko Ivanov (2):
tests: fix small syntax glitch
tests: add minimal test for LXC_NAME hosts entry
src/test/snapshot-test.pm | 12 +++++------
src/test/test-alpine-003/config | 2 ++
src/test/test-alpine-003/etc/alpine-release | 1 +
src/test/test-alpine-003/etc/hostname.exp | 1 +
src/test/test-alpine-003/etc/hosts | 3 +++
src/test/test-alpine-003/etc/hosts.exp | 5 +++++
.../test-alpine-003/etc/network/interfaces | 0
src/test/test-alpine-003/etc/passwd | 21 +++++++++++++++++++
.../roothome/.ssh/authorized_keys.exp | 3 +++
9 files changed, 42 insertions(+), 6 deletions(-)
create mode 100644 src/test/test-alpine-003/config
create mode 100644 src/test/test-alpine-003/etc/alpine-release
create mode 100644 src/test/test-alpine-003/etc/hostname.exp
create mode 100644 src/test/test-alpine-003/etc/hosts
create mode 100644 src/test/test-alpine-003/etc/hosts.exp
create mode 100644 src/test/test-alpine-003/etc/network/interfaces
create mode 100644 src/test/test-alpine-003/etc/passwd
create mode 100644 src/test/test-alpine-003/roothome/.ssh/authorized_keys.exp
--
2.30.2
next reply other threads:[~2023-06-14 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 12:33 Stoiko Ivanov [this message]
2023-06-14 12:33 ` [pve-devel] [PATCH container v2 1/2] tests: fix small syntax glitch Stoiko Ivanov
2023-06-14 12:33 ` [pve-devel] [PATCH container v2 2/2] tests: add minimal test for LXC_NAME hosts entry Stoiko Ivanov
2023-06-14 14:25 ` [pve-devel] applied-series: [PATCH container v2 0/2] add test for LXC_NAME hosts entry and fix a minor glitch Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614123325.4122277-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox