public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix #4739: ui: add group column in user list
Date: Wed, 14 Jun 2023 14:31:31 +0200	[thread overview]
Message-ID: <20230614123131.3772334-1-d.csapak@proxmox.com> (raw)

to get a fast overview in which groups each user is.

for that we need to add the 'full=1' parameter.

this only tokens/groups to the api call, but we have that info in the
backend after parsing the config anyway, so it should not be very
costly.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/dc/UserView.js       | 6 ++++++
 www/manager6/form/UserSelector.js | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js
index 957ff682..39ca15ec 100644
--- a/www/manager6/dc/UserView.js
+++ b/www/manager6/dc/UserView.js
@@ -217,6 +217,12 @@ Ext.define('PVE.dc.UserView', {
 		    },
 		    dataIndex: 'keys',
 		},
+		{
+		    header: gettext('Groups'),
+		    dataIndex: 'groups',
+		    renderer: Ext.htmlEncode,
+		    flex: 1,
+		},
 		{
 		    header: gettext('Comment'),
 		    sortable: false,
diff --git a/www/manager6/form/UserSelector.js b/www/manager6/form/UserSelector.js
index 8fb31d7e..5af30441 100644
--- a/www/manager6/form/UserSelector.js
+++ b/www/manager6/form/UserSelector.js
@@ -7,7 +7,7 @@ Ext.define('pmx-users', {
     ],
     proxy: {
 	type: 'proxmox',
-	url: "/api2/json/access/users",
+	url: "/api2/json/access/users?full=1",
     },
     idProperty: 'userid',
 });
-- 
2.30.2





             reply	other threads:[~2023-06-14 12:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 12:31 Dominik Csapak [this message]
2023-06-14 14:18 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230614123131.3772334-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal