From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"
Date: Wed, 14 Jun 2023 13:28:53 +0200 [thread overview]
Message-ID: <20230614112853.1560191-1-a.lauterer@proxmox.com> (raw)
This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15.
The bug should be fixed by now [0]. The reproducer doesn't cause any
issues in my tests.
[0] https://github.com/openzfs/zfs/issues/8541
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
AFAICT this has an affect on EFI disks which after this revert will be
528k and not 1M. Similar as if we would store it as a .raw file.
I don't know about other tiny volume datasets. The TPM is 4M already.
src/PVE/Storage/ZFSPoolPlugin.pm | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/PVE/Storage/ZFSPoolPlugin.pm b/src/PVE/Storage/ZFSPoolPlugin.pm
index 951d027..9a11d48 100644
--- a/src/PVE/Storage/ZFSPoolPlugin.pm
+++ b/src/PVE/Storage/ZFSPoolPlugin.pm
@@ -312,12 +312,7 @@ sub zfs_get_pool_stats {
sub zfs_create_zvol {
my ($class, $scfg, $zvol, $size) = @_;
-
- # always align size to 1M as workaround until
- # https://github.com/zfsonlinux/zfs/issues/8541 is solved
- my $padding = (1024 - $size % 1024) % 1024;
- $size = $size + $padding;
-
+
my $cmd = ['create'];
push @$cmd, '-s' if $scfg->{sparse};
--
2.39.2
next reply other threads:[~2023-06-14 11:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 11:28 Aaron Lauterer [this message]
2023-06-14 11:38 ` Thomas Lamprecht
2023-06-14 11:44 ` Aaron Lauterer
2023-06-14 12:13 ` Fiona Ebner
2023-06-14 12:26 ` Aaron Lauterer
-- strict thread matches above, loose matches on Subject: below --
2021-06-09 13:54 Aaron Lauterer
2021-06-10 12:33 ` Fabian Ebner
2021-06-11 9:28 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614112853.1560191-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox