From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] ui: config panel: only set onlineHelp if it exists
Date: Wed, 14 Jun 2023 11:50:46 +0200 [thread overview]
Message-ID: <20230614095047.2132289-1-d.csapak@proxmox.com> (raw)
otherwise we might run into an exception further down
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/panel/ConfigPanel.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/www/manager6/panel/ConfigPanel.js b/www/manager6/panel/ConfigPanel.js
index d578f944..5192d2bc 100644
--- a/www/manager6/panel/ConfigPanel.js
+++ b/www/manager6/panel/ConfigPanel.js
@@ -130,7 +130,10 @@ Ext.define('PVE.panel.Config', {
if (me.savedItems[cardid]) {
var curcard = me.getLayout().getActiveItem();
var newcard = me.add(me.savedItems[cardid]);
- me.helpButton.setOnlineHelp(newcard.onlineHelp || me.onlineHelp);
+ let onlineHelp = newcard.onlineHelp || me.onlineHelp;
+ if (onlineHelp) {
+ me.helpButton.setOnlineHelp(onlineHelp);
+ }
if (curcard) {
me.setActiveItem(cardid);
me.remove(curcard, true);
--
2.30.2
next reply other threads:[~2023-06-14 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 9:50 Dominik Csapak [this message]
2023-06-14 9:50 ` [pve-devel] [PATCH manager 2/2] ui: group storages in folder view Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614095047.2132289-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox