From: Alexander Zeidler <a.zeidler@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Alexander Zeidler <a.zeidler@proxmox.com>
Subject: [pve-devel] [PATCH manager 2/4] add 'pbs-entries-max' to permission check & config
Date: Tue, 13 Jun 2023 15:42:52 +0200 [thread overview]
Message-ID: <20230613134254.153081-3-a.zeidler@proxmox.com> (raw)
In-Reply-To: <20230613134254.153081-1-a.zeidler@proxmox.com>
configuring pbs-entries-max can avoid failing backups due to a high
amount of files in folders where a folder exclusion is not possible
Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
PVE/API2/Backup.pm | 2 +-
configs/vzdump.conf | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
index cae889f4..4fd495e2 100644
--- a/PVE/API2/Backup.pm
+++ b/PVE/API2/Backup.pm
@@ -49,7 +49,7 @@ sub assert_param_permission_common {
raise_param_exc({ $key => "Only root may set this option."}) if exists $param->{$key};
}
- for my $key (qw(bwlimit ionice performance)) {
+ for my $key (qw(bwlimit ionice performance pbs-entries-max)) {
if (defined($param->{$key})) {
$rpcenv->check($user, "/", [ 'Sys.Modify' ]);
last;
diff --git a/configs/vzdump.conf b/configs/vzdump.conf
index 2ea09ae0..2fbf3999 100644
--- a/configs/vzdump.conf
+++ b/configs/vzdump.conf
@@ -16,3 +16,4 @@
#exclude-path: PATHLIST
#pigz: N
#notes-template: {{guestname}}
+#pbs-entries-max: N
--
2.39.2
next prev parent reply other threads:[~2023-06-13 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 13:42 [pve-devel] [PATCH manager/container/guest-common 0/4] fix #3069: add pbs-entries-max to vzdump.conf Alexander Zeidler
2023-06-13 13:42 ` [pve-devel] [PATCH manager 1/4] api: backup: refactor backup permission check Alexander Zeidler
2023-06-14 9:49 ` Fiona Ebner
2023-06-13 13:42 ` Alexander Zeidler [this message]
2023-06-13 13:42 ` [pve-devel] [PATCH container 3/4] add 'pbs-entries-max' parameter Alexander Zeidler
2023-06-14 9:49 ` Fiona Ebner
2023-06-13 13:42 ` [pve-devel] [PATCH guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property Alexander Zeidler
2023-06-14 9:49 ` Fiona Ebner
2023-06-14 12:51 ` Fiona Ebner
2023-06-14 13:57 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613134254.153081-3-a.zeidler@proxmox.com \
--to=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox