public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH widget-toolkit] window: addtotp: Increase the size of the quiet zone
@ 2023-06-13 13:32 Maximiliano Sandoval
  2023-06-16 13:56 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2023-06-13 13:32 UTC (permalink / raw)
  To: pve-devel

It is recommended that the quiet zone has the width of 4 blocks, since
each block is around 4 pixels each, we need a margin of 16 pixels and a
size of 256 + 2 * 16 pixels.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/window/AddTotp.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/window/AddTotp.js b/src/window/AddTotp.js
index 53fdaad..ac8f32d 100644
--- a/src/window/AddTotp.js
+++ b/src/window/AddTotp.js
@@ -224,10 +224,10 @@ Ext.define('Proxmox.window.AddTotp', {
 			visible: '{!secretEmpty}',
 		    },
 		    style: {
-			margin: '5px auto',
-			padding: '5px',
-			width: '266px',
-			height: '266px',
+			margin: '16px auto',
+			padding: '16px',
+			width: '288px',
+			height: '288px',
 			'background-color': 'white',
 		    },
 		},
-- 
2.39.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH widget-toolkit] window: addtotp: Increase the size of the quiet zone
  2023-06-13 13:32 [pve-devel] [PATCH widget-toolkit] window: addtotp: Increase the size of the quiet zone Maximiliano Sandoval
@ 2023-06-16 13:56 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-06-16 13:56 UTC (permalink / raw)
  To: Proxmox VE development discussion, Maximiliano Sandoval

Am 13/06/2023 um 15:32 schrieb Maximiliano Sandoval:
> It is recommended that the quiet zone has the width of 4 blocks, since
> each block is around 4 pixels each, we need a margin of 16 pixels and a
> size of 256 + 2 * 16 pixels.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/window/AddTotp.js | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-16 13:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-13 13:32 [pve-devel] [PATCH widget-toolkit] window: addtotp: Increase the size of the quiet zone Maximiliano Sandoval
2023-06-16 13:56 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal