public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH zfsonlinux 0/2] update to 2.1.12
@ 2023-06-13  9:57 Stoiko Ivanov
  2023-06-13  9:57 ` [pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule " Stoiko Ivanov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2023-06-13  9:57 UTC (permalink / raw)
  To: pve-devel

ZFS 2.1.12 got released one week ago [0].

Some commits fix data-corruption with mmap on rollback or clone.
The issue with mountpoint=legacy mounts for rpool in Proxmox VE were
addressed by reverting the change that introduced it [1].

Potential performance-optimization in [2,3,4]

Improved handling of drive replacements [5] and draid-resilvering [6]

The additional patch pulled from debian upstream is small enough and seems
sensible

did some very superficial tests (migrate a container with replicaton
config forth and back and running ztest for 20 minutes), on 2 VMs upgraded
to bookworm.

Stoiko Ivanov (2):
  update zfs submodule to 2.1.12
  /lib/zfs-linux/trim: don't exit 1 if last pool isn't nvme-only
    (Closes: #1030316)

[0] https://github.com/openzfs/zfs/releases/tag/zfs-2.1.12
[1] https://github.com/openzfs/zfs/pull/14908
[2] https://github.com/openzfs/zfs/pull/14493
[3] https://github.com/openzfs/zfs/pull/12790
[4] https://github.com/openzfs/zfs/pull/14428
[5] https://github.com/openzfs/zfs/pull/14861
[6] https://github.com/openzfs/zfs/pull/14892

 debian/tree/zfsutils-linux/usr/lib/zfs-linux/trim | 2 +-
 upstream                                          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule to 2.1.12
  2023-06-13  9:57 [pve-devel] [PATCH zfsonlinux 0/2] update to 2.1.12 Stoiko Ivanov
@ 2023-06-13  9:57 ` Stoiko Ivanov
  2023-06-13  9:57 ` [pve-devel] [PATCH zfsonlinux 2/2] /lib/zfs-linux/trim: don't exit 1 if last pool isn't nvme-only (Closes: #1030316) Stoiko Ivanov
  2023-06-13 14:48 ` [pve-devel] applied-series: [PATCH zfsonlinux 0/2] update to 2.1.12 Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2023-06-13  9:57 UTC (permalink / raw)
  To: pve-devel

patches still applied cleanly

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 upstream | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/upstream b/upstream
index e25f9131..86783d7d 160000
--- a/upstream
+++ b/upstream
@@ -1 +1 @@
-Subproject commit e25f9131d679692704c11dc0c1df6d4585b70c35
+Subproject commit 86783d7d92cf7a859464719a917fdff845b9a9e1
-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH zfsonlinux 2/2] /lib/zfs-linux/trim: don't exit 1 if last pool isn't nvme-only (Closes: #1030316)
  2023-06-13  9:57 [pve-devel] [PATCH zfsonlinux 0/2] update to 2.1.12 Stoiko Ivanov
  2023-06-13  9:57 ` [pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule " Stoiko Ivanov
@ 2023-06-13  9:57 ` Stoiko Ivanov
  2023-06-13 14:48 ` [pve-devel] applied-series: [PATCH zfsonlinux 0/2] update to 2.1.12 Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2023-06-13  9:57 UTC (permalink / raw)
  To: pve-devel

(cherry picked from debian-upstream[0]
commit 8ed69adac193f6463832f6ae34b5ded88b8014d8)

[0] https://salsa.debian.org/zfsonlinux-team/zfs
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 debian/tree/zfsutils-linux/usr/lib/zfs-linux/trim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/tree/zfsutils-linux/usr/lib/zfs-linux/trim b/debian/tree/zfsutils-linux/usr/lib/zfs-linux/trim
index 341a2fbb..a807ecc5 100755
--- a/debian/tree/zfsutils-linux/usr/lib/zfs-linux/trim
+++ b/debian/tree/zfsutils-linux/usr/lib/zfs-linux/trim
@@ -60,7 +60,7 @@ do
 	case "${ret}" in
 		disable);;
 		enable)	trim_if_not_already_trimming "${pool}" ;;
-		-|auto)	pool_is_nvme_only "${pool}" && trim_if_not_already_trimming "${pool}" ;;
+		-|auto)	if pool_is_nvme_only "${pool}"; then trim_if_not_already_trimming "${pool}"; fi ;;
 		*)	cat > /dev/stderr <<EOF
 $0: [WARNING] illegal value "${ret}" for property "${PROPERTY_NAME}" of ZFS dataset "${pool}".
 $0: Acceptable choices for this property are: auto, enable, disable. The default is auto.
-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] applied-series: [PATCH zfsonlinux 0/2] update to 2.1.12
  2023-06-13  9:57 [pve-devel] [PATCH zfsonlinux 0/2] update to 2.1.12 Stoiko Ivanov
  2023-06-13  9:57 ` [pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule " Stoiko Ivanov
  2023-06-13  9:57 ` [pve-devel] [PATCH zfsonlinux 2/2] /lib/zfs-linux/trim: don't exit 1 if last pool isn't nvme-only (Closes: #1030316) Stoiko Ivanov
@ 2023-06-13 14:48 ` Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2023-06-13 14:48 UTC (permalink / raw)
  To: Proxmox VE development discussion, Stoiko Ivanov

Am 13/06/2023 um 11:57 schrieb Stoiko Ivanov:
> ZFS 2.1.12 got released one week ago [0].
> 
> Some commits fix data-corruption with mmap on rollback or clone.
> The issue with mountpoint=legacy mounts for rpool in Proxmox VE were
> addressed by reverting the change that introduced it [1].
> 
> Potential performance-optimization in [2,3,4]
> 
> Improved handling of drive replacements [5] and draid-resilvering [6]
> 
> The additional patch pulled from debian upstream is small enough and seems
> sensible
> 
> did some very superficial tests (migrate a container with replicaton
> config forth and back and running ztest for 20 minutes), on 2 VMs upgraded
> to bookworm.
> 
> Stoiko Ivanov (2):
>   update zfs submodule to 2.1.12
>   /lib/zfs-linux/trim: don't exit 1 if last pool isn't nvme-only
>     (Closes: #1030316)
> 
> [0] https://github.com/openzfs/zfs/releases/tag/zfs-2.1.12
> [1] https://github.com/openzfs/zfs/pull/14908
> [2] https://github.com/openzfs/zfs/pull/14493
> [3] https://github.com/openzfs/zfs/pull/12790
> [4] https://github.com/openzfs/zfs/pull/14428
> [5] https://github.com/openzfs/zfs/pull/14861
> [6] https://github.com/openzfs/zfs/pull/14892
> 
>  debian/tree/zfsutils-linux/usr/lib/zfs-linux/trim | 2 +-
>  upstream                                          | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 


applied both patches, thanks!




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-06-13 14:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-13  9:57 [pve-devel] [PATCH zfsonlinux 0/2] update to 2.1.12 Stoiko Ivanov
2023-06-13  9:57 ` [pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule " Stoiko Ivanov
2023-06-13  9:57 ` [pve-devel] [PATCH zfsonlinux 2/2] /lib/zfs-linux/trim: don't exit 1 if last pool isn't nvme-only (Closes: #1030316) Stoiko Ivanov
2023-06-13 14:48 ` [pve-devel] applied-series: [PATCH zfsonlinux 0/2] update to 2.1.12 Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal