From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 3/4] ui: realm: move sync job panel into realm panel
Date: Tue, 13 Jun 2023 10:44:00 +0200 [thread overview]
Message-ID: <20230613084401.1282876-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20230613084401.1282876-1-d.csapak@proxmox.com>
and make it collapsible, so that users can hide it if they're not
interested in it
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* fix eslint warning
www/manager6/dc/AuthView.js | 2 +-
www/manager6/dc/Config.js | 28 ++++++++++++++++++++--------
2 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/www/manager6/dc/AuthView.js b/www/manager6/dc/AuthView.js
index 60332c3f..229c944b 100644
--- a/www/manager6/dc/AuthView.js
+++ b/www/manager6/dc/AuthView.js
@@ -130,11 +130,11 @@ Ext.define('PVE.dc.AuthView', {
},
],
listeners: {
- activate: () => me.reload(),
itemdblclick: () => me.run_editor(),
},
});
me.callParent();
+ me.reload();
},
});
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index 72a9bec1..810a5d04 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -134,18 +134,30 @@ Ext.define('PVE.dc.Config', {
itemId: 'roles',
},
{
- xtype: 'pveAuthView',
title: gettext('Realms'),
+ xtype: 'panel',
+ layout: {
+ type: 'border',
+ },
groups: ['permissions'],
iconCls: 'fa fa-address-book-o',
itemId: 'domains',
- },
- {
- xtype: 'pveRealmSyncJobView',
- title: gettext('Realm Sync'),
- groups: ['permissions'],
- iconCls: 'fa fa-refresh',
- itemId: 'realmsyncjobs',
+ items: [
+ {
+ xtype: 'pveAuthView',
+ region: 'center',
+ border: false,
+ },
+ {
+ xtype: 'pveRealmSyncJobView',
+ title: gettext('Sync Jobs'),
+ region: 'south',
+ collapsible: true,
+ animCollapse: false,
+ border: false,
+ height: '50%',
+ },
+ ],
},
{
xtype: 'pveHAStatus',
--
2.30.2
next prev parent reply other threads:[~2023-06-13 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 8:43 [pve-devel] [PATCH manager v2 0/4] improve ui for reaml sync jobs Dominik Csapak
2023-06-13 8:43 ` [pve-devel] [PATCH manager v2 1/4] ui: realm sync edit: improve ux when there is no ldap/ad realm Dominik Csapak
2023-06-14 15:42 ` [pve-devel] applied-series: " Thomas Lamprecht
2023-06-13 8:43 ` [pve-devel] [PATCH manager v2 2/4] ui: realm sync: change enabled column rendering Dominik Csapak
2023-06-13 8:44 ` Dominik Csapak [this message]
2023-06-13 8:44 ` [pve-devel] [PATCH manager v2 4/4] ui: realm sync: add 'run now' button Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613084401.1282876-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox