From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 2/4] ui: realm sync: change enabled column rendering
Date: Tue, 13 Jun 2023 10:43:59 +0200 [thread overview]
Message-ID: <20230613084401.1282876-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20230613084401.1282876-1-d.csapak@proxmox.com>
to make it consistent with the repositories ui, since having a checkbox
that is not clickable is confusing
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/RealmSyncJob.js | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/www/manager6/dc/RealmSyncJob.js b/www/manager6/dc/RealmSyncJob.js
index e12ad858..9541d732 100644
--- a/www/manager6/dc/RealmSyncJob.js
+++ b/www/manager6/dc/RealmSyncJob.js
@@ -49,16 +49,19 @@ Ext.define('PVE.dc.RealmSyncJobView', {
},
},
+ viewConfig: {
+ getRowClass: (record, _index) => record.get('enabled') ? '' : 'proxmox-disabled-row',
+ },
+
columns: [
{
header: gettext('Enabled'),
width: 80,
dataIndex: 'enabled',
- xtype: 'checkcolumn',
sortable: true,
- disabled: true,
- disabledCls: 'x-item-enabled',
+ align: 'center',
stopSelection: false,
+ renderer: Proxmox.Utils.renderEnabledIcon,
},
{
text: gettext('Name'),
--
2.30.2
next prev parent reply other threads:[~2023-06-13 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 8:43 [pve-devel] [PATCH manager v2 0/4] improve ui for reaml sync jobs Dominik Csapak
2023-06-13 8:43 ` [pve-devel] [PATCH manager v2 1/4] ui: realm sync edit: improve ux when there is no ldap/ad realm Dominik Csapak
2023-06-14 15:42 ` [pve-devel] applied-series: " Thomas Lamprecht
2023-06-13 8:43 ` Dominik Csapak [this message]
2023-06-13 8:44 ` [pve-devel] [PATCH manager v2 3/4] ui: realm: move sync job panel into realm panel Dominik Csapak
2023-06-13 8:44 ` [pve-devel] [PATCH manager v2 4/4] ui: realm sync: add 'run now' button Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613084401.1282876-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox