From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 1/2] apt repositories: fix typo for getting the default unknown text
Date: Fri, 9 Jun 2023 16:16:25 +0200 [thread overview]
Message-ID: <20230609141626.4766-1-f.ebner@proxmox.com> (raw)
Could lead to a type error with classifyOrigin when there is a
repository that doesn't have an InRelease file and cannot be detected
as Debian/Proxmox origin from its URL. For me, it triggered with the
element.io repository after changing to bookworm (which currently
doesn't exist yet) and running apt update.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Not too difficult to run into with external repos during upgrade
preparation (when they are not yet bookworm-ready), so might also be
worth it for the stable branch?
src/node/APTRepositories.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index cba9271..47c0a2c 100644
--- a/src/node/APTRepositories.js
+++ b/src/node/APTRepositories.js
@@ -697,7 +697,7 @@ Ext.define('Proxmox.node.APTRepositories', {
repo.Path = file.path;
repo.Index = n;
if (infos[file.path] && infos[file.path][n]) {
- repo.Origin = infos[file.path][n].origin || Proxmox.Utils.UnknownText;
+ repo.Origin = infos[file.path][n].origin || Proxmox.Utils.unknownText;
repo.warnings = infos[file.path][n].warnings || [];
if (repo.Enabled) {
--
2.39.2
next reply other threads:[~2023-06-09 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 14:16 Fiona Ebner [this message]
2023-06-09 14:16 ` [pve-devel] [PATCH widget-toolkit 2/2] apt repositories: avoid potential type error in classifyOrigin helper Fiona Ebner
2023-06-09 15:35 ` [pve-devel] applied-series: Re: [PATCH widget-toolkit 1/2] apt repositories: fix typo for getting the default unknown text Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609141626.4766-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox