From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container] setup: systemd-network: use correct values for dhcp-modes
Date: Fri, 9 Jun 2023 15:05:51 +0200 [thread overview]
Message-ID: <20230609130551.338045-1-s.ivanov@proxmox.com> (raw)
the change from v4->ipv4 happened 2015 in systemd commit
cb9fc36a1211967e8c58b0502a26c42552ac8060 - so by now it should be
safe to replace it for all containers relying on systemd-networkd.
This change follows fb554c701f1e9cac4b278fd6b82a4f2b45da8acf (in
pve-container) but in this case the issue is only cosmetic for now.
Noticed with a current arch-linux container
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
src/PVE/LXC/Setup/Base.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
index c88bf03..5534397 100644
--- a/src/PVE/LXC/Setup/Base.pm
+++ b/src/PVE/LXC/Setup/Base.pm
@@ -261,7 +261,7 @@ DATA
my ($has_ipv4, $has_ipv6);
# DHCP bitflags:
- my @DHCPMODES = ('no', 'v4', 'v6', 'yes');
+ my @DHCPMODES = ('no', 'ipv4', 'ipv6', 'yes');
my ($NONE, $DHCP4, $DHCP6, $BOTH) = (0, 1, 2, 3);
my $dhcp = $NONE;
my $accept_ra = 'false';
--
2.30.2
next reply other threads:[~2023-06-09 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 13:05 Stoiko Ivanov [this message]
2023-06-09 15:38 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609130551.338045-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox