From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 qemu-server, container, docs 0/7] migration: don't scan all storages, fail on aliases
Date: Thu, 1 Jun 2023 15:53:35 +0200 [thread overview]
Message-ID: <20230601135342.2903359-1-a.lauterer@proxmox.com> (raw)
This patch series changes the behavior during guest migrations:
Don't scan all storages for potential images belonging to the guest.
Only migrate images referenced in the config.
This made it necessary to handle pending changes explicitly which had
been covered by the storage scan.
We also added checks for any aliased volids and fail the migration if
detected.
The patches in qemu-server and pve-container are split int two. The
first ones handle the change from scanning the storages to handle only
referenced images. The second one adds the alias check.
There is also a small patch for the documentation to add a hint that
aliased storages should be avoided.
changes since v2:
- style fixes
- qemu-server: mainly change the handling of pending changes
- container: use NEW_DISK_RE to check if the volume is a not yet created
pending volume
More in each patch.
qemu-server: Aaron Lauterer (4):
migration: only migrate disks used by the guest
tests: add migration test for pending disk
migration: fail when aliased volume is detected
tests: add migration alias check
PVE/QemuMigrate.pm | 98 ++++++-----------
PVE/QemuServer.pm | 9 +-
test/MigrationTest/QemuMigrateMock.pm | 9 ++
test/run_qemu_migrate_tests.pl | 151 +++++++++++++++++++++++++-
4 files changed, 198 insertions(+), 69 deletions(-)
container: Aaron Lauterer (2):
migration: only migrate volumes used by the guest
migration: fail when aliased volume is detected
src/PVE/LXC/Migrate.pm | 51 +++++++++++++++++-------------------------
1 file changed, 21 insertions(+), 30 deletions(-)
docs: Aaron Lauterer (1):
storage: add hint to avoid storage aliasing
pvesm.adoc | 3 +++
1 file changed, 3 insertions(+)
--
2.30.2
next reply other threads:[~2023-06-01 13:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 13:53 Aaron Lauterer [this message]
2023-06-01 13:53 ` [pve-devel] [PATCH v3 qemu-server 1/7] migration: only migrate disks used by the guest Aaron Lauterer
2023-06-02 9:45 ` Fiona Ebner
2023-06-02 9:50 ` Fiona Ebner
2023-06-05 12:43 ` Aaron Lauterer
2023-06-01 13:53 ` [pve-devel] [PATCH v3 qemu-server 2/7] tests: add migration test for pending disk Aaron Lauterer
2023-06-01 13:53 ` [pve-devel] [PATCH v3 qemu-server 3/7] migration: fail when aliased volume is detected Aaron Lauterer
2023-06-01 13:53 ` [pve-devel] [PATCH v3 qemu-server 4/7] tests: add migration alias check Aaron Lauterer
2023-06-02 11:29 ` Fiona Ebner
2023-06-01 13:53 ` [pve-devel] [PATCH v3 container 5/7] migration: only migrate volumes used by the guest Aaron Lauterer
2023-06-02 11:42 ` Fiona Ebner
2023-06-01 13:53 ` [pve-devel] [PATCH v3 container 6/7] migration: fail when aliased volume is detected Aaron Lauterer
2023-06-01 13:53 ` [pve-devel] [PATCH v3 docs 7/7] storage: add hint to avoid storage aliasing Aaron Lauterer
2023-06-02 11:51 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601135342.2903359-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox