From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES v2 pve-manager/qemu-server] fix#4689 autofind node with proxyto_callback
Date: Thu, 1 Jun 2023 08:50:08 +0200 [thread overview]
Message-ID: <20230601065011.2946694-1-aderumier@odiso.com> (raw)
Hi,
Currently, to manage qemu && lxc vms, we always need to specify nodename in uri.
This is a problem with automation tools like terraform, where is node is registered
in the state of terraform.
(That mean, than if we move the vm on another node, terraform don't known it, and try to create the vm
again or can't delete the vm,...)
https://github.com/Telmate/terraform-provider-proxmox/issues/168
This can also be a potential problem with race, if we need to query /cluster/ressources to find the node, then another
query on the vm.
I have some discussion with fabian about it:
https://bugzilla.proxmox.com/show_bug.cgi?id=4689
This patch series, find the nodename with proxyto_callback.
a new api endpoint /guests/ is defined:
/guests/(qemu|lxc)/vmid
This patch series currently implement callback for api2::qemu
todo (if this patch serie is ok for you):
api2::qemu::agent (/guest/qemu/vmid/agent)
api2::lxc (/guest/lxc/vmid)
api2::lxc::config (/guest/lxc/vmid/config)
api2::lxc::status (/guest/lxc/vmid/status)
api2::lxc::snapshot (/guest/lxc/vmid/snapshot)
api2::firewall:vm (/guest/(qemu|lxc)/vmid/firewall )
changelog v2:
- fix pvesh param sending to proxyto_callback
pve-manager:
Alexandre Derumier (2):
api2: add /guests path
pvesh: send params to check_proxyto like httpserver
PVE/API2.pm | 6 +++++
PVE/API2/Guests.pm | 55 ++++++++++++++++++++++++++++++++++++++++++++++
PVE/API2/Makefile | 1 +
PVE/CLI/pvesh.pm | 13 ++++++-----
4 files changed, 70 insertions(+), 5 deletions(-)
create mode 100644 PVE/API2/Guests.pm
qemu-server:
Alexandre Derumier (1):
api2: qemu: add proxyto_callback to find node if not defined
PVE/API2/Qemu.pm | 157 ++++++++++++++++++++++++++++++++---------------
1 file changed, 109 insertions(+), 48 deletions(-)
--
2.30.2
next reply other threads:[~2023-06-01 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 6:50 Alexandre Derumier [this message]
2023-06-01 6:50 ` [pve-devel] [PATCH pve-manager 1/2] api2: add /guests path Alexandre Derumier
2023-06-01 6:50 ` [pve-devel] [PATCH qemu-server 1/1] api2: qemu: add proxyto_callback to find node if not defined Alexandre Derumier
2023-06-01 6:50 ` [pve-devel] [PATCH pve-manager 2/2] pvesh: send params to check_proxyto like httpserver Alexandre Derumier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601065011.2946694-1-aderumier@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox