public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH ifupdown2 5/6] patch: remove lacp bond min-links=0 warning
Date: Tue, 16 May 2023 00:47:09 +0200	[thread overview]
Message-ID: <20230515224710.1331004-6-aderumier@odiso.com> (raw)
In-Reply-To: <20230515224710.1331004-1-aderumier@odiso.com>

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
 ...bond-remove-bond-min-links-0-warning.patch | 33 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 34 insertions(+)
 create mode 100644 debian/patches/pve/0013-lacp-bond-remove-bond-min-links-0-warning.patch

diff --git a/debian/patches/pve/0013-lacp-bond-remove-bond-min-links-0-warning.patch b/debian/patches/pve/0013-lacp-bond-remove-bond-min-links-0-warning.patch
new file mode 100644
index 0000000..089b315
--- /dev/null
+++ b/debian/patches/pve/0013-lacp-bond-remove-bond-min-links-0-warning.patch
@@ -0,0 +1,33 @@
+From df1e76e6bcdca3044ee9d53ddb62a71bedf4b8a6 Mon Sep 17 00:00:00 2001
+From: Alexandre Derumier <aderumier@odiso.com>
+Date: Tue, 16 May 2023 00:33:36 +0200
+Subject: [PATCH] lacp bond: remove bond-min-links=0 warning
+
+This is only cumulus specific
+
+Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
+---
+ ifupdown2/addons/bond.py | 7 -------
+ 1 file changed, 7 deletions(-)
+
+diff --git a/ifupdown2/addons/bond.py b/ifupdown2/addons/bond.py
+index 74d2cab..4a555cc 100644
+--- a/ifupdown2/addons/bond.py
++++ b/ifupdown2/addons/bond.py
+@@ -610,13 +610,6 @@ class bond(Addon, moduleBase):
+             # if we need to reset the mode to system default
+             ifla_info_data[Link.IFLA_BOND_MODE] = ifla_bond_mode
+ 
+-        if ifla_bond_mode == 4:  # 802.3ad
+-            min_links = ifla_info_data.get(Link.IFLA_BOND_MIN_LINKS)
+-            if min_links is None:
+-                min_links = self.cache.get_link_info_data_attribute(ifname, Link.IFLA_BOND_MIN_LINKS)
+-            # get_min_links_nl may return None so we need to strictly check 0
+-            if min_links == 0:
+-                self.logger.warning('%s: attribute bond-min-links is set to \'0\'' % ifname)
+         else:
+             # IFLA_BOND_AD_LACP_RATE and IFLA_BOND_AD_LACP_BYPASS only for 802.3ad mode (4)
+             for nl_attr, attr_name in self._bond_lacp_attrs:
+-- 
+2.30.2
+
diff --git a/debian/patches/series b/debian/patches/series
index 8edf054..ab3863c 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -10,4 +10,5 @@ pve/0009-postinst-rm-update-network-config-compatibility.patch
 pve/0010-d-rules-drop-now-default-with-systemd.patch
 pve/0011-d-rules-add-dh_installsystemd-override-for-compat-12.patch
 pve/0012-postinst-reload-network-config-on-first-install.patch
+pve/0013-lacp-bond-remove-bond-min-links-0-warning.patch
 upstream/0001-add-ipv6-slaac-support-inet6-auto-accept_ra.patch
\ No newline at end of file
-- 
2.30.2




  parent reply	other threads:[~2023-05-15 22:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15 22:47 [pve-devel] [PATCH ifupdown2 0/6] bump to 3.2.0 Alexandre Derumier
2023-05-15 22:47 ` [pve-devel] [PATCH ifupdown2 1/6] patch: patch5: fix code nit Alexandre Derumier
2023-05-15 22:47 ` [pve-devel] [PATCH ifupdown2 2/6] patch: remove old upstreamed patches Alexandre Derumier
2023-05-15 22:47 ` [pve-devel] [PATCH ifupdown2 3/6] patch: reorder patches Alexandre Derumier
2023-05-15 22:47 ` [pve-devel] [PATCH ifupdown2 4/6] patch: add ipv6 slaac support upstream patch Alexandre Derumier
2023-05-15 22:47 ` Alexandre Derumier [this message]
2023-05-15 22:47 ` [pve-devel] [PATCH ifupdown2 6/6] bump version to 3.2.0-1+pmx1 Alexandre Derumier
2023-05-20 14:22 ` [pve-devel] applied: [PATCH ifupdown2 0/6] bump to 3.2.0 Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230515224710.1331004-6-aderumier@odiso.com \
    --to=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal