From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container v2 6/6] migration: fail when aliased volume is detected
Date: Fri, 12 May 2023 14:40:43 +0200 [thread overview]
Message-ID: <20230512124043.888785-7-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20230512124043.888785-1-a.lauterer@proxmox.com>
Aliased volumes (referencing the same volume multiple times) can lead to
unexpected behavior in a migration.
Therefore, stop the migration in such a case.
The check works by comparing the path returned by the storage plugin.
This means that we should be able to catch the common situations where
it can happen:
* by referencing the same volid multiple times
* having a different volid due to an aliased storage: different storage
name but pointing to the same location.
We decided against checking the storages themselves being aliased. It is
not possible to infer that reliably from just the storage configuration
options alone.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
src/PVE/LXC/Migrate.pm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index 8e11be7..e542ce7 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/LXC/Migrate.pm
@@ -182,6 +182,7 @@ sub phase1 {
my $volhash = {}; # 'config', 'snapshot' or 'storage' for local volumes
my $volhash_errors = {};
my $abort = 0;
+ my $path_to_volid = {};
my $log_error = sub {
my ($msg, $volid) = @_;
@@ -236,6 +237,8 @@ sub phase1 {
die "owned by other guest (owner = $owner)\n"
if !$owner || ($owner != $self->{vmid});
+ $path_to_volid->{$path}->{$volid} = 1;
+
if (defined($snapname)) {
# we cannot migrate shapshots on local storage
# exceptions: 'zfspool', 'btrfs'
@@ -282,6 +285,12 @@ sub phase1 {
# finally all current volumes
PVE::LXC::Config->foreach_volume_full($conf, { include_unused => 1 }, $test_mp);
+ for my $path (keys %$path_to_volid) {
+ my @volids = keys %{$path_to_volid->{$path}};
+ die "detected not supported aliased volumes: '" . join("', '", @volids) . "'"
+ if (scalar @volids > 1);
+ }
+
# additional checks for local storage
foreach my $volid (keys %$volhash) {
eval {
--
2.30.2
prev parent reply other threads:[~2023-05-12 12:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 12:40 [pve-devel] [PATCH qemu-server, container v2 0/6] migration: don't scan all storages, fail on aliases Aaron Lauterer
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 1/6] migration: only migrate disks used by the guest Aaron Lauterer
2023-05-22 11:59 ` Fiona Ebner
2023-05-24 15:00 ` Aaron Lauterer
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 2/6] tests: add migration test for pending disk Aaron Lauterer
2023-05-22 14:02 ` Fiona Ebner
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 3/6] migration: fail when aliased volume is detected Aaron Lauterer
2023-05-22 14:17 ` Fiona Ebner
2023-05-24 14:40 ` Aaron Lauterer
2023-05-25 8:14 ` Fiona Ebner
2023-05-25 8:15 ` Fiona Ebner
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 4/6] tests: add migration alias check Aaron Lauterer
2023-05-22 14:25 ` Fiona Ebner
2023-05-24 14:41 ` Aaron Lauterer
2023-05-12 12:40 ` [pve-devel] [PATCH container v2 5/6] migration: only migrate volumes used by the guest Aaron Lauterer
2023-05-22 15:00 ` Fiona Ebner
2023-05-12 12:40 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230512124043.888785-7-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox