From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server, container v2 0/6] migration: don't scan all storages, fail on aliases
Date: Fri, 12 May 2023 14:40:37 +0200 [thread overview]
Message-ID: <20230512124043.888785-1-a.lauterer@proxmox.com> (raw)
v1 was the series: avoid migrating disk images multiple times
We decided to take a different approach to avoid migrating potentially
aliased disk images / volumes in a migration.
Do not scan the storages for potential images belonging to the guest.
Only migrate images referenced in the config. This made it necessary to
add steps that used to be covered by the initial storage scan.
Especially pending changes need to be handled explicitly.
The patches are split in two parts for each repo, first remove the scan
of all storages, secondly we check for aliases and fail.
Due to the hard fail, this series is intended for Proxmox VE 8!
More details in the patches themselves.
qemu-server: Aaron Lauterer (4):
migration: only migrate disks used by the guest
tests: add migration test for pending disk
migration: fail when aliased volume is detected
tests: add migration alias check
PVE/QemuMigrate.pm | 81 ++++++++--------
test/MigrationTest/QemuMigrateMock.pm | 10 ++
test/run_qemu_migrate_tests.pl | 132 ++++++++++++++++++++++++--
3 files changed, 173 insertions(+), 50 deletions(-)
container: Aaron Lauterer (2):
migration: only migrate volumes used by the guest
migration: fail when aliased volume is detected
src/PVE/LXC/Migrate.pm | 56 ++++++++++++++++++++----------------------
1 file changed, 26 insertions(+), 30 deletions(-)
--
2.30.2
next reply other threads:[~2023-05-12 12:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 12:40 Aaron Lauterer [this message]
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 1/6] migration: only migrate disks used by the guest Aaron Lauterer
2023-05-22 11:59 ` Fiona Ebner
2023-05-24 15:00 ` Aaron Lauterer
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 2/6] tests: add migration test for pending disk Aaron Lauterer
2023-05-22 14:02 ` Fiona Ebner
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 3/6] migration: fail when aliased volume is detected Aaron Lauterer
2023-05-22 14:17 ` Fiona Ebner
2023-05-24 14:40 ` Aaron Lauterer
2023-05-25 8:14 ` Fiona Ebner
2023-05-25 8:15 ` Fiona Ebner
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 4/6] tests: add migration alias check Aaron Lauterer
2023-05-22 14:25 ` Fiona Ebner
2023-05-24 14:41 ` Aaron Lauterer
2023-05-12 12:40 ` [pve-devel] [PATCH container v2 5/6] migration: only migrate volumes used by the guest Aaron Lauterer
2023-05-22 15:00 ` Fiona Ebner
2023-05-12 12:40 ` [pve-devel] [PATCH container v2 6/6] migration: fail when aliased volume is detected Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230512124043.888785-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox