* [pve-devel] [PATCH storage] changed regex to allow @ in directory storage paths
@ 2023-04-27 12:04 Markus Frank
2023-06-07 7:14 ` [pve-devel] applied: " Wolfgang Bumiller
0 siblings, 1 reply; 2+ messages in thread
From: Markus Frank @ 2023-04-27 12:04 UTC (permalink / raw)
To: pve-devel
@ is often used to signify btrfs subvolumes.
Signed-off-by: Markus Frank <m.frank@proxmox.com>
---
PVE/Storage/DirPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Storage/DirPlugin.pm b/PVE/Storage/DirPlugin.pm
index 9e305f5..d7a1b7e 100644
--- a/PVE/Storage/DirPlugin.pm
+++ b/PVE/Storage/DirPlugin.pm
@@ -230,7 +230,7 @@ sub check_config {
my ($self, $sectionId, $config, $create, $skipSchemaCheck) = @_;
my $opts = PVE::SectionConfig::check_config($self, $sectionId, $config, $create, $skipSchemaCheck);
return $opts if !$create;
- if ($opts->{path} !~ m@^/[-/a-zA-Z0-9_.]+$@) {
+ if ($opts->{path} !~ m|^/[-/a-zA-Z0-9_.@]+$|) {
die "illegal path for directory storage: $opts->{path}\n";
}
return $opts;
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH storage] changed regex to allow @ in directory storage paths
2023-04-27 12:04 [pve-devel] [PATCH storage] changed regex to allow @ in directory storage paths Markus Frank
@ 2023-06-07 7:14 ` Wolfgang Bumiller
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Bumiller @ 2023-06-07 7:14 UTC (permalink / raw)
To: Markus Frank; +Cc: pve-devel
applied, thanks
once we can be sure there are no bad `system("foo $path bar");` calls
anywhere we might be able to drop this check entirely...
some day...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-07 7:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-27 12:04 [pve-devel] [PATCH storage] changed regex to allow @ in directory storage paths Markus Frank
2023-06-07 7:14 ` [pve-devel] applied: " Wolfgang Bumiller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox