From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/3] fix #4678: ui: don't sort storage backup content by vmid by default
Date: Thu, 20 Apr 2023 10:06:14 +0200 [thread overview]
Message-ID: <20230420080616.836255-1-d.csapak@proxmox.com> (raw)
instead, add the vmid as extra column, so that the user can still sort
by vmid if they wish to
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/storage/BackupView.js | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js
index fbdf573d3..9ad1a4915 100644
--- a/www/manager6/storage/BackupView.js
+++ b/www/manager6/storage/BackupView.js
@@ -220,16 +220,20 @@ Ext.define('PVE.storage.BackupView', {
},
},
};
+ } else {
+ me.extraColumns = {};
}
+ me.extraColumns.vmid = {
+ header: gettext('VMID'),
+ dataIndex: 'vmid',
+ hidden: true,
+ sorter: (a, b) => a.data.vmid - b.data.vmid,
+ };
me.callParent();
me.store.getSorters().clear();
me.store.setSorters([
- {
- property: 'vmid',
- direction: 'ASC',
- },
{
property: 'vdate',
direction: 'DESC',
--
2.30.2
next reply other threads:[~2023-04-20 8:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 8:06 Dominik Csapak [this message]
2023-04-20 8:06 ` [pve-devel] [PATCH manager 2/3] ui: make storage backup content stateful Dominik Csapak
2023-04-22 7:21 ` Thomas Lamprecht
2023-04-20 8:06 ` [pve-devel] [RFC PATCH manager 3/3] ui: enable multiColumnSort for storage backup content Dominik Csapak
2023-04-20 13:39 ` Aaron Lauterer
2023-04-22 7:21 ` Thomas Lamprecht
2023-04-22 7:38 ` [pve-devel] [PATCH manager 1/3] fix #4678: ui: don't sort storage backup content by vmid by default Thomas Lamprecht
2023-04-22 7:52 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420080616.836255-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox