From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] ui: clone: validate name
Date: Mon, 17 Apr 2023 09:09:13 +0200 [thread overview]
Message-ID: <20230417070914.13808-1-f.ebner@proxmox.com> (raw)
As reported in the community forum[0], as opposed to VM/LXC creation,
there is no validation for the name in the clone dialog. Use the same
validation as the guest creation wizards do to catch errors early,
before sending the API request.
[0]: https://forum.proxmox.com/threads/125883/#post-549304
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
www/manager6/window/Clone.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/window/Clone.js b/www/manager6/window/Clone.js
index e94cd92d..e4ea17ad 100644
--- a/www/manager6/window/Clone.js
+++ b/www/manager6/window/Clone.js
@@ -191,6 +191,7 @@ Ext.define('PVE.window.Clone', {
{
xtype: 'textfield',
name: 'name',
+ vtype: 'DnsName',
allowBlank: true,
fieldLabel: me.guestType === 'lxc' ? gettext('Hostname') : gettext('Name'),
},
--
2.30.2
next reply other threads:[~2023-04-17 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 7:09 Fiona Ebner [this message]
2023-04-17 7:09 ` [pve-devel] [PATCH manager 2/2] ui: backup restore: " Fiona Ebner
2023-04-24 10:10 ` [pve-devel] applied-series: [PATCH manager 1/2] ui: clone: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417070914.13808-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox