[pve-devel] [PATCH manager] fix #4605: drop rsyncable from zstd invocation

[pve-devel] [PATCH manager] fix #4605: drop rsyncable from zstd invocation

[Fabian Grünbichler]

it causes severe slow downs on fast disks, and we still have other rsyncable
compressors available.

it was originally added based on wrong documentation that made the performance
impact look a lot smaller than it actually is.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---

Notes:
    IMHO, we can always re-introduce it as configurable opt-in option if somebody
    really needs this combination.. and most things for which you might want
    rsyncable are better off just using PBS nowadays anyway.

 PVE/VZDump.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index a04837e7..f574950e 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -757,7 +757,7 @@ sub compressor_info {
 	    my $cpuinfo = PVE::ProcFSTools::read_cpuinfo();
 	    $zstd_threads = int(($cpuinfo->{cpus} + 1)/2);
 	}
-	return ("zstd --rsyncable --threads=${zstd_threads}", 'zst');
+	return ("zstd --threads=${zstd_threads}", 'zst');
     } else {
 	die "internal error - unknown compression option '$opt_compress'";
     }
-- 
2.30.2

[pve-devel] applied: [PATCH manager] fix #4605: drop rsyncable from zstd invocation

[Thomas Lamprecht]

Am 17/04/2023 um 09:04 schrieb Fabian Grünbichler:
> it causes severe slow downs on fast disks, and we still have other rsyncable
> compressors available.
> 
> it was originally added based on wrong documentation that made the performance
> impact look a lot smaller than it actually is.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     IMHO, we can always re-introduce it as configurable opt-in option if somebody
>     really needs this combination.. and most things for which you might want
>     rsyncable are better off just using PBS nowadays anyway.
> 
>  PVE/VZDump.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!