[pve-devel] [PATCH pve-manager 0/1] fixing gettext problems

[pve-devel] [PATCH pve-manager 0/1] fixing gettext problems

[Daniel Koć]

Hi,

I wanted to make the translation of Proxmox apps more complete and
there are multiple places where gettext() is missing. I would be 
happy to add it wherever possible to give translators more power,
but I'd like to fix at least most visible gaps. Here is my first try
to do that.

I'm not a developer and I don't plan to be one, so it's hard for me
to do everything properly. Especially I did not test the changes,
since instructions to make devel environment look pretty complex to
me. If there is a quick way to easily update JS and POT files on
running PVE environment, I would be happy to use it.

There are some cases where gettext blocks are already here, but are
not visible, so it would be good to fix that too, but I don't know
how. Examples from fresh PVE 7.4-3 installation:

- native language names are not visible on the login page and in the
  top right menu, even if they are translated
  
- Hint "Without any keep option, the storage's configuration or 
  node's vzdump.conf is used as fallback" is already gettextized in
  www/manager6/dc/Backup.js, but I see original string instead
  
Any comments are welcome.

Daniel Koć (1):
  adding missing gettext

 www/manager6/ceph/FS.js         | 4 ++--
 www/manager6/ceph/OSD.js        | 6 +++---
 www/manager6/ceph/OSDDetails.js | 2 +-
 www/manager6/form/VLanField.js  | 2 +-
 www/manager6/ha/Fencing.js      | 4 ++--
 www/manager6/ha/GroupEdit.js    | 2 +-
 www/manager6/node/Config.js     | 2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)

-- 
2.34.1

[pve-devel] [PATCH pve-manager 1/1] adding missing gettext

[Daniel Koć]

---
 www/manager6/ceph/FS.js         | 4 ++--
 www/manager6/ceph/OSD.js        | 6 +++---
 www/manager6/ceph/OSDDetails.js | 2 +-
 www/manager6/form/VLanField.js  | 2 +-
 www/manager6/ha/Fencing.js      | 4 ++--
 www/manager6/ha/GroupEdit.js    | 2 +-
 www/manager6/node/Config.js     | 2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/www/manager6/ceph/FS.js b/www/manager6/ceph/FS.js
index e9815355..d93aacd1 100644
--- a/www/manager6/ceph/FS.js
+++ b/www/manager6/ceph/FS.js
@@ -156,12 +156,12 @@ Ext.define('PVE.NodeCephFSPanel', {
 		    dataIndex: 'name',
 		},
 		{
-		    header: 'Data Pool',
+		    header: gettext('Data Pool'),
 		    flex: 1,
 		    dataIndex: 'data_pool',
 		},
 		{
-		    header: 'Metadata Pool',
+		    header: gettext('Metadata Pool'),
 		    flex: 1,
 		    dataIndex: 'metadata_pool',
 		},
diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
index 2f12f94d..69d5061f 100644
--- a/www/manager6/ceph/OSD.js
+++ b/www/manager6/ceph/OSD.js
@@ -73,7 +73,7 @@ Ext.define('PVE.CephCreateOsd', {
 			    value: '',
 			    autoSelect: false,
 			    allowBlank: true,
-			    emptyText: 'use OSD disk',
+			    emptyText: gettext('use OSD disk'),
 			    listeners: {
 				change: function(field, val) {
 				    me.down('field[name=db_dev_size]').setDisabled(!val);
@@ -112,7 +112,7 @@ Ext.define('PVE.CephCreateOsd', {
 			    autoSelect: false,
 			    allowBlank: true,
 			    editable: true,
-			    emptyText: 'auto detect',
+			    emptyText: gettext('auto detect'),
 			    deleteEmpty: !me.isCreate,
 			},
 		    ],
@@ -127,7 +127,7 @@ Ext.define('PVE.CephCreateOsd', {
 			    value: '',
 			    autoSelect: false,
 			    allowBlank: true,
-			    emptyText: 'use OSD/DB disk',
+			    emptyText: gettext('use OSD/DB disk'),
 			    listeners: {
 				change: function(field, val) {
 				    me.down('field[name=wal_dev_size]').setDisabled(!val);
diff --git a/www/manager6/ceph/OSDDetails.js b/www/manager6/ceph/OSDDetails.js
index 24af8f15..f0765d4f 100644
--- a/www/manager6/ceph/OSDDetails.js
+++ b/www/manager6/ceph/OSDDetails.js
@@ -196,7 +196,7 @@ Ext.define('PVE.CephOsdDetails', {
 			},
 			{
 			    xtype: 'panel',
-			    title: 'Devices',
+			    title: gettext('Devices'),
 			    tooltip: gettext('Physical devices used by the OSD'),
 			    items: [
 				{
diff --git a/www/manager6/form/VLanField.js b/www/manager6/form/VLanField.js
index 7379789a..b2db5569 100644
--- a/www/manager6/form/VLanField.js
+++ b/www/manager6/form/VLanField.js
@@ -4,7 +4,7 @@ Ext.define('PVE.form.VlanField', {
 
     deleteEmpty: false,
 
-    emptyText: 'no VLAN',
+    emptyText: gettext('no VLAN'),
 
     fieldLabel: gettext('VLAN Tag'),
 
diff --git a/www/manager6/ha/Fencing.js b/www/manager6/ha/Fencing.js
index c87a761c..4005afd9 100644
--- a/www/manager6/ha/Fencing.js
+++ b/www/manager6/ha/Fencing.js
@@ -18,11 +18,11 @@ Ext.define('PVE.ha.FencingView', {
 	    viewConfig: {
 		trackOver: false,
 		deferEmptyText: false,
-		emptyText: 'Use watchdog based fencing.',
+		emptyText: gettext('Use watchdog based fencing.'),
 	    },
 	    columns: [
 		{
-		    header: 'Node',
+		    header: gettext('Node'),
 		    width: 100,
 		    sortable: true,
 		    dataIndex: 'node',
diff --git a/www/manager6/ha/GroupEdit.js b/www/manager6/ha/GroupEdit.js
index 2c42de6b..6db7bd05 100644
--- a/www/manager6/ha/GroupEdit.js
+++ b/www/manager6/ha/GroupEdit.js
@@ -69,7 +69,7 @@ Ext.define('PVE.ha.GroupInputPanel', {
 		    dataIndex: 'cpu',
 		},
 		{
-		    header: 'Priority',
+		    header: gettext('Priority'),
 		    xtype: 'widgetcolumn',
 		    dataIndex: 'priority',
 		    sortable: true,
diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
index 0cc23fb4..6ed2172a 100644
--- a/www/manager6/node/Config.js
+++ b/www/manager6/node/Config.js
@@ -373,7 +373,7 @@ Ext.define('PVE.node.Config', {
 		},
 		{
 		    xtype: 'pveNodeCephPoolList',
-		    title: 'Pools',
+		    title: gettext('Pools'),
 		    iconCls: 'fa fa-sitemap',
 		    groups: ['ceph'],
 		    itemId: 'ceph-pools',
-- 
2.34.1

Re: [pve-devel] [PATCH pve-manager 1/1] adding missing gettext

[Thomas Lamprecht]

Am 16/04/2023 um 05:29 schrieb Daniel Koć:

Ok, but is missing your Signed-off-by developer certificate of origin, you can either
reply here with the S-o-b line, or resend the patch with it amended to the commit
message (in that case please also change the commit subject to start with "ui: "),
whatever you prefer.

> ---
>  www/manager6/ceph/FS.js         | 4 ++--
>  www/manager6/ceph/OSD.js        | 6 +++---
>  www/manager6/ceph/OSDDetails.js | 2 +-
>  www/manager6/form/VLanField.js  | 2 +-
>  www/manager6/ha/Fencing.js      | 4 ++--
>  www/manager6/ha/GroupEdit.js    | 2 +-
>  www/manager6/node/Config.js     | 2 +-
>  7 files changed, 11 insertions(+), 11 deletions(-)
> 

Re: [pve-devel] [PATCH pve-manager 1/1] adding missing gettext

[Daniel Koć]

Sure:

Signed-off-by: Daniel Koć<daniel@xn--ko-wla.pl>


W dniu 17.04.2023 o 14:43, Thomas Lamprecht pisze:
> Am 16/04/2023 um 05:29 schrieb Daniel Koć:
>
> Ok, but is missing your Signed-off-by developer certificate of origin, you can either
> reply here with the S-o-b line, or resend the patch with it amended to the commit
> message (in that case please also change the commit subject to start with "ui: "),
> whatever you prefer.
>
>> ---
>>   www/manager6/ceph/FS.js         | 4 ++--
>>   www/manager6/ceph/OSD.js        | 6 +++---
>>   www/manager6/ceph/OSDDetails.js | 2 +-
>>   www/manager6/form/VLanField.js  | 2 +-
>>   www/manager6/ha/Fencing.js      | 4 ++--
>>   www/manager6/ha/GroupEdit.js    | 2 +-
>>   www/manager6/node/Config.js     | 2 +-
>>   7 files changed, 11 insertions(+), 11 deletions(-)
>>
>
>
>
-- 
"이상하고 별나지만" [우영우]

[pve-devel] applied: [PATCH pve-manager 1/1] adding missing gettext

[Thomas Lamprecht]

On 16/04/2023 05:29, Daniel Koć wrote:
> ---
>  www/manager6/ceph/FS.js         | 4 ++--
>  www/manager6/ceph/OSD.js        | 6 +++---
>  www/manager6/ceph/OSDDetails.js | 2 +-
>  www/manager6/form/VLanField.js  | 2 +-
>  www/manager6/ha/Fencing.js      | 4 ++--
>  www/manager6/ha/GroupEdit.js    | 2 +-
>  www/manager6/node/Config.js     | 2 +-
>  7 files changed, 11 insertions(+), 11 deletions(-)
> 
>

applied, with adding your S-o-b and rewriting the commit subject a bit, thanks!