public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Daniel Koć" <daniel@xn--ko-wla.pl>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager 0/1] fixing gettext problems
Date: Sun, 16 Apr 2023 05:29:38 +0200	[thread overview]
Message-ID: <20230416032939.3850877-1-daniel@xn--ko-wla.pl> (raw)

Hi,

I wanted to make the translation of Proxmox apps more complete and
there are multiple places where gettext() is missing. I would be 
happy to add it wherever possible to give translators more power,
but I'd like to fix at least most visible gaps. Here is my first try
to do that.

I'm not a developer and I don't plan to be one, so it's hard for me
to do everything properly. Especially I did not test the changes,
since instructions to make devel environment look pretty complex to
me. If there is a quick way to easily update JS and POT files on
running PVE environment, I would be happy to use it.

There are some cases where gettext blocks are already here, but are
not visible, so it would be good to fix that too, but I don't know
how. Examples from fresh PVE 7.4-3 installation:

- native language names are not visible on the login page and in the
  top right menu, even if they are translated
  
- Hint "Without any keep option, the storage's configuration or 
  node's vzdump.conf is used as fallback" is already gettextized in
  www/manager6/dc/Backup.js, but I see original string instead
  
Any comments are welcome.

Daniel Koć (1):
  adding missing gettext

 www/manager6/ceph/FS.js         | 4 ++--
 www/manager6/ceph/OSD.js        | 6 +++---
 www/manager6/ceph/OSDDetails.js | 2 +-
 www/manager6/form/VLanField.js  | 2 +-
 www/manager6/ha/Fencing.js      | 4 ++--
 www/manager6/ha/GroupEdit.js    | 2 +-
 www/manager6/node/Config.js     | 2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)

-- 
2.34.1




             reply	other threads:[~2023-04-16  3:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-16  3:29 Daniel Koć [this message]
2023-04-16  3:29 ` [pve-devel] [PATCH pve-manager 1/1] adding missing gettext Daniel Koć
2023-04-17 12:43   ` Thomas Lamprecht
2023-04-17 13:02     ` Daniel Koć
2023-04-24 10:04   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230416032939.3850877-1-daniel@xn--ko-wla.pl \
    --to=daniel@xn--ko-wla.pl \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal