public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 4/4] dark-mode: improve apt repo group header contrast ratios
Date: Wed,  5 Apr 2023 10:08:05 +0200	[thread overview]
Message-ID: <20230405080805.525170-5-s.sterz@proxmox.com> (raw)
In-Reply-To: <20230405080805.525170-1-s.sterz@proxmox.com>

make the group headers darker, so that they have some contrast with
the surrounding rows. also add back the border at the bottom. both
changes improve the legibility of the table.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/proxmox/_nodes.scss | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/proxmox-dark/scss/proxmox/_nodes.scss b/src/proxmox-dark/scss/proxmox/_nodes.scss
index 02b15f9..84f9127 100644
--- a/src/proxmox-dark/scss/proxmox/_nodes.scss
+++ b/src/proxmox-dark/scss/proxmox/_nodes.scss
@@ -1,7 +1,7 @@
 // Table headers under Node > "Updates" > "Repositories"
 .proxmox-apt-repos .x-grid-group-hd {
-  background-color: $background-darker;
-  border-bottom-width: 0;
+  background-color: $background-darkest;
+  border-color: $border-color-alt;
 }
 
 .proxmox-apt-repos .x-grid-group-title {
-- 
2.30.2





  parent reply	other threads:[~2023-04-05  8:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05  8:08 [pve-devel] [PATCH widget-toolkit 0/4] Proxmox Dark Theme Fix-ups - Round 5 Stefan Sterz
2023-04-05  8:08 ` [pve-devel] [PATCH widget-toolkit 1/4] dark-mode: fix focus and focus-over states for tabs Stefan Sterz
2023-04-05  8:08 ` [pve-devel] [PATCH widget-toolkit 2/4] dark-mode: fix the focused state for background image grid icons Stefan Sterz
2023-04-05  8:08 ` [pve-devel] [PATCH widget-toolkit 3/4] dark-mode: style the icon for the maintenance mode in pbs Stefan Sterz
2023-04-05  8:08 ` Stefan Sterz [this message]
2023-04-06 11:10 ` [pve-devel] applied-series: [PATCH widget-toolkit 0/4] Proxmox Dark Theme Fix-ups - Round 5 Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230405080805.525170-5-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal