public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-offline-mirror 1/2] pool: drop redundant quote for paths..
Date: Tue,  4 Apr 2023 13:21:14 +0200	[thread overview]
Message-ID: <20230404112115.184009-1-f.gruenbichler@proxmox.com> (raw)

a Path(Buf)'s Debug formatting already contains double quotes, no need to quote
it a second time..

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 src/pool.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pool.rs b/src/pool.rs
index 7a67087..3da8c08 100644
--- a/src/pool.rs
+++ b/src/pool.rs
@@ -483,12 +483,12 @@ impl PoolLockGuard<'_> {
 
                 match actual_link_count.cmp(&expected_link_count) {
                     std::cmp::Ordering::Less => {
-                        println!("Something fishy going on with '{path:?}'");
+                        println!("Something fishy going on with {path:?}");
                         false
                     }
                     std::cmp::Ordering::Equal => {
                         // only checksum files remaining
-                        println!("Removing '{:?}'", &path);
+                        println!("Removing {path:?}");
                         true
                     }
                     std::cmp::Ordering::Greater => {
-- 
2.30.2





             reply	other threads:[~2023-04-04 11:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04 11:21 Fabian Grünbichler [this message]
2023-04-04 11:21 ` [pve-devel] [PATCH proxmox-offline-mirror 2/2] fix #4261: allow GC for all configured mirrors Fabian Grünbichler
2023-04-06 11:25   ` [pve-devel] applied: " Thomas Lamprecht
2023-04-06 11:25 ` [pve-devel] applied: [PATCH proxmox-offline-mirror 1/2] pool: drop redundant quote for paths Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230404112115.184009-1-f.gruenbichler@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal