public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix #4627: ui: backup edit: don't deselect all vms on load
Date: Fri, 31 Mar 2023 12:03:08 +0200	[thread overview]
Message-ID: <20230331100308.1922021-1-d.csapak@proxmox.com> (raw)

'selectPoolMembers' will be called when the poolid field changes.
(That can even happen when the mode is not even 'pool')
Due to how the fields are set, there is a race condition that this
will be called after the remaining fields were set up, including
the vm list that might have entires selected.

Since the first thing we do here is to deselect all, this wiped
the vm selection sometimes.

To fix it, check if we're actually in the correct mode before doing
anything.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/dc/Backup.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 7c6e244af..03a026513 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -96,6 +96,12 @@ Ext.define('PVE.dc.BackupEdit', {
 
 	selectPoolMembers: function() {
 	    let me = this;
+	    let mode = me.lookup('modeSelector').getValue();
+
+	    if (mode !== 'pool') {
+		return;
+	    }
+
 	    let vmgrid = me.lookup('vmgrid');
 	    let poolid = me.lookup('poolSelector').getValue();
 
-- 
2.30.2





             reply	other threads:[~2023-03-31 10:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 10:03 Dominik Csapak [this message]
2023-04-12 11:28 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230331100308.1922021-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal