[pve-devel] [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method

[pve-devel] [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method

[Friedrich Weber]

A previous commit (51083ee) added an override of the internal ExtJS
method `Ext.data.Store.onProxyLoad` in order to fix a race condition.
This override calls `Operation.getProxy`. However, this method is not
available on Sencha Touch. As a consequence, the mobile UI was broken.

This commit modifies the override such that it has no effect in the
mobile UI.

Fixes: 51083ee54aa98af5a711622e4ed240840dcbbabe
Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
 src/Utils.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/Utils.js b/src/Utils.js
index 7b7a83a..3200884 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -1483,10 +1483,11 @@ Ext.override(Ext.data.Store, {
     // If the store's proxy is changed while it is waiting for an AJAX
     // response, `onProxyLoad` will still be called for the outdated response.
     // To avoid displaying inconsistent information, only process responses
-    // belonging to the current proxy.
+    // belonging to the current proxy. However, do not apply this workaround
+    // to the mobile UI, as Sencha Touch has an incompatible internal API.
     onProxyLoad: function(operation) {
 	let me = this;
-	if (operation.getProxy() === me.getProxy()) {
+	if (Proxmox.Utils.toolkit === 'touch' || operation.getProxy() === me.getProxy()) {
 	    me.callParent(arguments);
 	} else {
 	    console.log(`ignored outdated response: ${operation.getRequest().getUrl()}`);
-- 
2.30.2

Re: [pve-devel] [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method

[Dominik Csapak]

works, LGTM

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>

[pve-devel] applied: [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method

[Thomas Lamprecht]

Am 24/03/2023 um 10:02 schrieb Friedrich Weber:
> A previous commit (51083ee) added an override of the internal ExtJS
> method `Ext.data.Store.onProxyLoad` in order to fix a race condition.
> This override calls `Operation.getProxy`. However, this method is not
> available on Sencha Touch. As a consequence, the mobile UI was broken.
> 
> This commit modifies the override such that it has no effect in the
> mobile UI.
> 
> Fixes: 51083ee54aa98af5a711622e4ed240840dcbbabe
> Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
>  src/Utils.js | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
>

applied, thanks!