[pve-devel] [PATCH pve-widget-toolkit 0/2] fix 4524: Language names should be translated

[pve-devel] [PATCH pve-widget-toolkit 0/2] fix 4524: Language names should be translated

[Noel Ullreich]

Translated the language names from English to their respective language
as well as added a translation of the language into the language
currently selected.

Once the patch is accepted, I would write the German translation in
the i18n repo. The bugzilla report also includes a French translation.
Can I include that as well or is that an issue for the signoff?

Noel Ullreich (2):
  Translated language dropdown menu in web interface
  increased language dropdown menu width

 src/Utils.js               | 50 +++++++++++++++++++-------------------
 src/window/LanguageEdit.js |  1 +
 2 files changed, 26 insertions(+), 25 deletions(-)

-- 
2.30.2

[pve-devel] [PATCH pve-widget-toolkit 1/2] Translated language dropdown menu in web interface

[Noel Ullreich]

Translated the languages in the web interface dropdown menu. Languages
used to be in English, now they are in their native language and
writing system along with their translation in the currently selected
language.

Signed-off-by: Noel Ullreich <n.ullreich@proxmox.com>
---
 src/Utils.js | 50 +++++++++++++++++++++++++-------------------------
 1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/src/Utils.js b/src/Utils.js
index 7b7a83a..3510590 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -62,31 +62,31 @@ utilities: {
     stateText: gettext('State'),
     groupText: gettext('Group'),
 
-    language_map: {
-	ar: 'Arabic',
-	ca: 'Catalan',
-	zh_CN: 'Chinese (Simplified)',
-	zh_TW: 'Chinese (Traditional)',
-	da: 'Danish',
-	nl: 'Dutch',
-	en: 'English',
-	eu: 'Euskera (Basque)',
-	fr: 'French',
-	de: 'German',
-	he: 'Hebrew',
-	it: 'Italian',
-	ja: 'Japanese',
-	kr: 'Korean',
-	nb: 'Norwegian (Bokmal)',
-	nn: 'Norwegian (Nynorsk)',
-	fa: 'Persian (Farsi)',
-	pl: 'Polish',
-	pt_BR: 'Portuguese (Brazil)',
-	ru: 'Russian',
-	sl: 'Slovenian',
-	es: 'Spanish',
-	sv: 'Swedish',
-	tr: 'Turkish',
+    language_map: { //language map is sorted alphabetically by iso 639-1
+	ar: 'العربية - '+gettext("Arabic"),
+	ca: 'Català - '+gettext("Catalan"),
+	da: 'Dansk - '+gettext("Danish"),
+	de: 'Deutsch - '+gettext("German"),
+	en: 'English - '+gettext("English"),
+	es: 'Español - '+gettext("Spanish"),
+	eu: 'Euskera (Basque) - '+gettext("Euskera (Basque)"),
+	fa: 'فارسی - '+gettext("Persian (Farsi)"),
+	fr: 'Français - '+gettext("French"),
+	he: 'עברית - '+gettext("Hebrew"),
+	it: 'Italiano - '+gettext("Italian"),
+	ja: '日本語 - '+gettext("Japanese"),
+	kr: '한국어 - '+gettext("Korean"),
+	nb: 'Bokmål - '+gettext("Norwegian (Bokmal)"),
+	nl: 'Nederlands - '+gettext("Dutch"),
+	nn: 'Nynorsk - '+gettext("Norwegian (Nynorsk)"),
+	pl: 'Polski - '+gettext("Polish"),
+	pt_BR: 'Português Brasileiro - '+gettext("Portuguese (Brazil)"),
+	ru: 'Русский - '+gettext("Russian"),
+	sl: 'Slovenščina - '+gettext("Slovenian"),
+	sv: 'Svenska - '+gettext("Swedish"),
+	tr: 'Türkçe - '+gettext("Turkish"),
+	zh_CN: '中文（简体） - '+gettext("Chinese (Simplified)"),
+	zh_TW: '中文（繁體） - '+gettext("Chinese (Traditional)"),
     },
 
     render_language: function(value) {
-- 
2.30.2

[pve-devel] applied: [PATCH pve-widget-toolkit 1/2] Translated language dropdown menu in web interface

[Thomas Lamprecht]

Am 23/03/2023 um 15:44 schrieb Noel Ullreich:
> Translated the languages in the web interface dropdown menu. Languages
> used to be in English, now they are in their native language and
> writing system along with their translation in the currently selected
> language.
> 
> Signed-off-by: Noel Ullreich <n.ullreich@proxmox.com>
> ---
>  src/Utils.js | 50 +++++++++++++++++++++++++-------------------------
>  1 file changed, 25 insertions(+), 25 deletions(-)
> 
>

applied, moved to template string in a follow up, thanks!

[pve-devel] [PATCH pve-widget-toolkit 2/2] increased language dropdown menu width

[Noel Ullreich]

With the new translations and layout, the width of the dropdown menu
needs to be increased so that the languages are all on the same line.
This width might need to increased in the future if translations were to
create a linebreak.

Signed-off-by: Noel Ullreich <n.ullreich@proxmox.com>
---
 src/window/LanguageEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/window/LanguageEdit.js b/src/window/LanguageEdit.js
index 9176cfd..e1ba6cc 100644
--- a/src/window/LanguageEdit.js
+++ b/src/window/LanguageEdit.js
@@ -38,6 +38,7 @@ Ext.define('Proxmox.window.LanguageEditWindow', {
 	    bind: {
 		value: '{language}',
 	    },
+	    width: 400,
 	},
     ],
     buttons: [
-- 
2.30.2

[pve-devel] applied: [PATCH pve-widget-toolkit 2/2] increased language dropdown menu width

[Thomas Lamprecht]

Am 23/03/2023 um 15:44 schrieb Noel Ullreich:
> With the new translations and layout, the width of the dropdown menu
> needs to be increased so that the languages are all on the same line.
> This width might need to increased in the future if translations were to
> create a linebreak.
> 
> Signed-off-by: Noel Ullreich <n.ullreich@proxmox.com>
> ---
>  src/window/LanguageEdit.js | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied first but then basically reverted it again and switched it out with
a patch [0] that only changes the width of picker, not the whole field, and
also reduces the field labelWidth from 100 px to 75 px, which is enough
for all translations here, to give the field a bit more space while keeping
our usual window size for such single/few parameter windows - thanks!

[0]: https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=311fb72a272a2c66e611d08e1950cb756f245838