[pve-devel] [PATCH widget-toolkit 1/3] dark-mode: fix highlighting of active elements in drop down menus

[pve-devel] [PATCH widget-toolkit 1/3] dark-mode: fix highlighting of active elements in drop down menus

[Stefan Sterz]

e.g.,: the filter menu item in the backup job creation window

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/extjs/_menu.scss | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/proxmox-dark/scss/extjs/_menu.scss b/src/proxmox-dark/scss/extjs/_menu.scss
index 74be901..2983f60 100644
--- a/src/proxmox-dark/scss/extjs/_menu.scss
+++ b/src/proxmox-dark/scss/extjs/_menu.scss
@@ -19,7 +19,8 @@
   }
 
   // When hovering over a menu item
-  &.x-menu-item-focus {
+  &.x-menu-item-focus,
+  &.x-menu-item-active {
     @include selection;
   }
 }
-- 
2.30.2

[pve-devel] [PATCH widget-toolkit 2/3] dark-mode: set the icon color of filtered column headers properly

[Stefan Sterz]

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/other/_icons.scss | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss
index b4443ee..aa36b54 100644
--- a/src/proxmox-dark/scss/other/_icons.scss
+++ b/src/proxmox-dark/scss/other/_icons.scss
@@ -28,7 +28,8 @@
 // e.g. permission tree view in pve
 .x-tree-icon-leaf:not(.x-tree-icon-custom)::before,
 .x-tree-icon-parent:not(.x-tree-icon-custom)::before,
-.x-tree-icon-parent-expanded:not(.x-tree-icon-custom)::before {
+.x-tree-icon-parent-expanded:not(.x-tree-icon-custom)::before,
+.x-grid-filters-filtered-column .x-column-header-text::after {
   color: $icon-color;
 }
 
-- 
2.30.2

[pve-devel] [PATCH widget-toolkit 3/3] dark-mode: style checkboxes that don't use blueish active states

[Stefan Sterz]

e.g., in the backup job creation window the filter column checkmark

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/other/_icons.scss | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss
index aa36b54..d492e2e 100644
--- a/src/proxmox-dark/scss/other/_icons.scss
+++ b/src/proxmox-dark/scss/other/_icons.scss
@@ -108,7 +108,10 @@
 .x-form-checkbox-default,
 .x-form-radio-default,
 .x-column-header-checkbox .x-column-header-checkbox::after,
-.x-grid-checkcolumn::after {
+.x-grid-checkcolumn::after,
+// checkboxes without the extra "blueish" active states
+.x-menu-item-checked .x-menu-item-icon-default.x-menu-item-checkbox,
+.x-menu-item-unchecked .x-menu-item-icon-default.x-menu-item-checkbox {
   filter: invert($icon-brightness) hue-rotate(180deg) brightness(125%);
 }
 
-- 
2.30.2

[pve-devel] [PATCH widget-toolkit] dark-mode: style locked guest icons properly

[Stefan Sterz]

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/other/_icons.scss | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss
index d492e2e..164cd35 100644
--- a/src/proxmox-dark/scss/other/_icons.scss
+++ b/src/proxmox-dark/scss/other/_icons.scss
@@ -131,6 +131,10 @@
     color: $icon-color-alt;
   }
 
+  &.locked::after {
+    color: $icon-color;
+  }
+
   &.lxc::after,
   &.qemu::after {
     background-color: $background-darker;
-- 
2.30.2

[pve-devel] applied-series: [PATCH widget-toolkit 1/3] dark-mode: fix highlighting of active elements in drop down menus

[Thomas Lamprecht]

Am 22/03/2023 um 12:07 schrieb Stefan Sterz:
> e.g.,: the filter menu item in the backup job creation window
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>  src/proxmox-dark/scss/extjs/_menu.scss | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied all four patches, thanks!