From: Christoph Heiss <c.heiss@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager 2/3] ui: qga: Add option to turn off QGA fs-freeze/-thaw on backup
Date: Tue, 21 Mar 2023 13:49:07 +0100 [thread overview]
Message-ID: <20230321124907.g65asygtn42eotik@maui.proxmox.com> (raw)
In-Reply-To: <145ebd0c-4ea3-7a4b-daad-60a10c1d4fea@proxmox.com>
On Tue, Mar 21, 2023 at 01:31:44PM +0100, Thomas Lamprecht wrote:
> Am 23/02/2023 um 15:18 schrieb Christoph Heiss:
> > [..]
> > + {
> > + xtype: 'displayfield',
> > + userCls: 'pmx-hint',
> > + value: gettext('Freeze/thaw for guest filesystems disabled. '
> > + + 'This can lead to inconsistent disk backups.'),
>
> gettext need to be in a single line - or fix the "parser" that scans for the
> messages in i18n ;-)
Okay, thanks for the hint! Guess I'll drop the the line wrapping for now.
(But the latter would be nice too as a kind of "future-proofing" I
suppose, I'll probably take a shot at it ..)
>
> > [..]
next prev parent reply other threads:[~2023-03-21 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 14:18 [pve-devel] [PATCH v2 qemu-server/manager/docs 0/3] fix #4140: Add option to disable " Christoph Heiss
2023-02-23 14:18 ` [pve-devel] [PATCH v2 qemu-server 1/3] vzdump: Add VM QGA option to skip " Christoph Heiss
2023-02-23 15:36 ` [pve-devel] applied: " Thomas Lamprecht
2023-02-23 14:18 ` [pve-devel] [PATCH v2 manager 2/3] ui: qga: Add option to turn off QGA " Christoph Heiss
2023-03-21 12:31 ` Thomas Lamprecht
2023-03-21 12:49 ` Christoph Heiss [this message]
2023-02-23 14:18 ` [pve-devel] [PATCH v2 docs 3/3] qm: Add section explaining fs-freeze/-thaw QGA option Christoph Heiss
2023-03-21 10:53 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321124907.g65asygtn42eotik@maui.proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox