From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-perl-rs 2/2] pve: test: resource scheduling: add test with overcommitted node
Date: Tue, 21 Mar 2023 13:33:45 +0100 [thread overview]
Message-ID: <20230321123345.128141-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230321123345.128141-1-f.ebner@proxmox.com>
which will fail with librust-proxmox-resource-scheduling-dev=0.1.0-1
Reported-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Build-depends on fixed proxmox-resource-scheduling
pve-rs/test/resource_scheduling.pl | 33 ++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/pve-rs/test/resource_scheduling.pl b/pve-rs/test/resource_scheduling.pl
index 9c48178..fbedfe1 100755
--- a/pve-rs/test/resource_scheduling.pl
+++ b/pve-rs/test/resource_scheduling.pl
@@ -54,7 +54,40 @@ sub test_balance {
}
}
+sub test_overcommitted {
+ my $static = PVE::RS::ResourceScheduling::Static->new();
+ $static->add_node("A", 4, 4_102_062_080);
+ $static->add_node("B", 4, 4_102_062_080);
+ $static->add_node("C", 4, 4_102_053_888);
+ $static->add_node("D", 4, 4_102_053_888);
+
+ my $service = {
+ maxcpu => 1,
+ maxmem => 536_870_912,
+ };
+
+ $static->add_service_usage_to_node("A", $service);
+ $static->add_service_usage_to_node("A", $service);
+ $static->add_service_usage_to_node("A", $service);
+ $static->add_service_usage_to_node("B", $service);
+ $static->add_service_usage_to_node("A", $service);
+
+ my $score_list = $static->score_nodes_to_start_service($service);
+
+ # imitate HA manager
+ my $scores = { map { $_->[0] => -$_->[1] } $score_list->@* };
+ my @nodes = sort {
+ $scores->{$a} <=> $scores->{$b} || $a cmp $b
+ } keys $scores->%*;
+
+ is($nodes[0], "C", 'first should be C');
+ is($nodes[1], "D", 'second should be D');
+ is($nodes[2], "B", 'third should be B');
+ is($nodes[3], "A", 'fourth should be A');
+}
+
test_basic();
test_balance();
+test_overcommitted();
done_testing();
--
2.30.2
next prev parent reply other threads:[~2023-03-21 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 12:33 [pve-devel] [PATCH-SERIES proxmox-{resource-scheduling, perl-rs}] fix scoring issue " Fiona Ebner
2023-03-21 12:33 ` [pve-devel] [PATCH proxmox-resource-scheduling 1/2] pve ha: fix scoring issue when a node is overcommitted compared to others Fiona Ebner
2023-03-21 12:33 ` [pve-devel] [PATCH proxmox-resource-scheduling 2/2] pve ha: fix typo in comment Fiona Ebner
2023-03-21 12:33 ` [pve-devel] [PATCH proxmox-perl-rs 1/2] pve: test: resource scheduling: use dedicated functions for tests Fiona Ebner
2023-03-21 12:33 ` Fiona Ebner [this message]
2023-03-21 14:25 ` [pve-devel] applied-series: [PATCH-SERIES proxmox-{resource-scheduling, perl-rs}] fix scoring issue with overcommitted node Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321123345.128141-5-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox