[pve-devel] [PATCH manager 1/2] ui: lvmthin: don't add nodeselector/enable multiple times in edit window

[pve-devel] [PATCH manager 1/2] ui: lvmthin: don't add nodeselector/enable multiple times in edit window

[Dominik Csapak]

seemingly an empty array is special for extjs, and if we push into it,
we overwrite the class definition of that property

this does not happen when something is already in the array, so
the other edit windows work as expected

to fix it here, remove the empty array entirely, since we already
create an empty one when we need it

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/storage/LvmThinEdit.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/www/manager6/storage/LvmThinEdit.js b/www/manager6/storage/LvmThinEdit.js
index bed5facb3..c3b55d87d 100644
--- a/www/manager6/storage/LvmThinEdit.js
+++ b/www/manager6/storage/LvmThinEdit.js
@@ -183,6 +183,4 @@ Ext.define('PVE.storage.LvmThinInputPanel', {
 	    allowBlank: false,
 	},
     ],
-
-    column2: [],
 });
-- 
2.30.2

[pve-devel] [PATCH manager 2/2] ui: lvmthin: fix not being able to edit the storage

[Dominik Csapak]

the change handler of the edit config from a displayeditfield still
triggers, even if not shown/disabled. sadly this enabled another
editconfig part of a displayeditfield, which triggers an error
in the api

to fix that, simply check if this field is disabled before setting
the other fields value

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/storage/LvmThinEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/storage/LvmThinEdit.js b/www/manager6/storage/LvmThinEdit.js
index c3b55d87d..63f1fd78f 100644
--- a/www/manager6/storage/LvmThinEdit.js
+++ b/www/manager6/storage/LvmThinEdit.js
@@ -148,7 +148,7 @@ Ext.define('PVE.storage.LvmThinInputPanel', {
 		    },
 		    change: function(f, value) {
 			let vgField = this.up('inputpanel').lookup('thinPoolSelector');
-			if (vgField) {
+			if (vgField && !f.isDisabled()) {
 			    vgField.setDisabled(!value);
 			    vgField.setVG(value);
 			    vgField.setValue('');
-- 
2.30.2

[pve-devel] applied: [PATCH manager 2/2] ui: lvmthin: fix not being able to edit the storage

[Thomas Lamprecht]

Am 21/03/2023 um 10:16 schrieb Dominik Csapak:
> the change handler of the edit config from a displayeditfield still
> triggers, even if not shown/disabled. sadly this enabled another
> editconfig part of a displayeditfield, which triggers an error
> in the api
> 
> to fix that, simply check if this field is disabled before setting
> the other fields value
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/storage/LvmThinEdit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied,  thanks!

[pve-devel] applied: [PATCH manager 1/2] ui: lvmthin: don't add nodeselector/enable multiple times in edit window

[Thomas Lamprecht]

Am 21/03/2023 um 10:16 schrieb Dominik Csapak:
> seemingly an empty array is special for extjs, and if we push into it,
> we overwrite the class definition of that property
> 
> this does not happen when something is already in the array, so
> the other edit windows work as expected
> 
> to fix it here, remove the empty array entirely, since we already
> create an empty one when we need it
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/storage/LvmThinEdit.js | 2 --
>  1 file changed, 2 deletions(-)
> 
>

applied, thanks!