From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 1/4] dark-theme: improve help button contrast ratios in focused state
Date: Mon, 20 Mar 2023 10:02:06 +0100 [thread overview]
Message-ID: <20230320090209.313745-2-s.sterz@proxmox.com> (raw)
In-Reply-To: <20230320090209.313745-1-s.sterz@proxmox.com>
also improves the hovered/focused state and makes it more consistent
with other buttons by making it brighter than the default state.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
src/proxmox-dark/scss/abstracts/_variables.scss | 2 +-
src/proxmox-dark/scss/proxmox/_helpbutton.scss | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/proxmox-dark/scss/abstracts/_variables.scss b/src/proxmox-dark/scss/abstracts/_variables.scss
index cf61ad2..29c9020 100644
--- a/src/proxmox-dark/scss/abstracts/_variables.scss
+++ b/src/proxmox-dark/scss/abstracts/_variables.scss
@@ -35,7 +35,7 @@ $neutral-button-icon-color: $neutral-button-text-color;
// Help Buttons
$help-button-color: hsl(0deg, 0%, 65%);
-$help-button-color-alt: hsl(0deg, 0%, 55%);
+$help-button-color-alt: hsl(0deg, 0%, 75%);
$help-button-text-color: hsl(0deg, 0%, 10%);
$help-button-icon-color: $help-button-text-color;
diff --git a/src/proxmox-dark/scss/proxmox/_helpbutton.scss b/src/proxmox-dark/scss/proxmox/_helpbutton.scss
index 817d6a1..5032cc1 100644
--- a/src/proxmox-dark/scss/proxmox/_helpbutton.scss
+++ b/src/proxmox-dark/scss/proxmox/_helpbutton.scss
@@ -5,7 +5,8 @@
color: $help-button-text-color;
&.x-btn-over,
- &.x-btn.x-btn-pressed.x-btn-default-toolbar-small {
+ &.x-btn.x-btn-pressed.x-btn-default-toolbar-small,
+ .x-keyboard-mode &.x-btn-default-toolbar-small.x-btn-focus {
background-color: $help-button-color-alt;
border-color: $help-button-color-alt;
}
--
2.30.2
next prev parent reply other threads:[~2023-03-20 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 9:02 [pve-devel] [PATCH widget-toolkit 0/4] Dark Theme Fix-ups Round 3 Stefan Sterz
2023-03-20 9:02 ` Stefan Sterz [this message]
2023-03-20 9:02 ` [pve-devel] [PATCH widget-toolkit 2/4] dark-theme: make "sorted-by" header highlight more subtle Stefan Sterz
2023-03-20 9:02 ` [pve-devel] [PATCH widget-toolkit 3/4] dark-theme: dim warning and invalid colors more Stefan Sterz
2023-03-20 9:02 ` [pve-devel] [PATCH widget-toolkit 4/4] dark-theme: let the background "shine through" mask more Stefan Sterz
2023-03-20 13:08 ` [pve-devel] applied: [PATCH widget-toolkit 0/4] Dark Theme Fix-ups Round 3 Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320090209.313745-2-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox