From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 manager 0/5] rework ceph cfg api & fix 2515 use size defaults
Date: Thu, 16 Mar 2023 14:48:15 +0100 [thread overview]
Message-ID: <20230316134820.1193518-1-a.lauterer@proxmox.com> (raw)
The main goal of this series is to improve the handling of configured
default size & min_size values when creating a new Ceph Pool in the GUI.
But since that means a new necessary API endpoint, we also rework the
Ceph API to make it cleaner.
A new API endpoint is used: 'cfg' and the current 'config' and
'configdb' are moved there (first 2 patches). The result is
* cfg/
* raw (formerly config)
* db (formerly configdb)
Then we add a new endpoint 'cfg/value' that allows us to fetch values
for config keys that are set either in the config DB of Ceph or in the
ceph.conf file.
More in each patch.
Depending on how we want to handle the API deprecation, we might just
want to apply the first two patches with 7.4, even if the actual
implementation of the fix itself will have to wait.
changes since v1:
* 2 new patches to rework API so that the new endpoint has its place
* incorporated suggested code changes
Aaron Lauterer (5):
api: ceph: add ceph/cfg path, deprecate ceph/config and ceph/configdb
ui: ceph config: use new ceph/cfg/ API endpoints
api: ceph: add endpoint to fetch config keys
fix #2515: ui: ceph pool create: use configured defaults for size and
min_size
ui: ceph pool edit: rework with controller and formulas
PVE/API2/Ceph.pm | 15 ++-
PVE/API2/Ceph/Cfg.pm | 197 ++++++++++++++++++++++++++++++++++++
PVE/API2/Ceph/Makefile | 1 +
www/manager6/ceph/Config.js | 4 +-
www/manager6/ceph/Pool.js | 144 +++++++++++++++++++-------
5 files changed, 321 insertions(+), 40 deletions(-)
create mode 100644 PVE/API2/Ceph/Cfg.pm
--
2.30.2
next reply other threads:[~2023-03-16 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 13:48 Aaron Lauterer [this message]
2023-03-16 13:48 ` [pve-devel] [PATCH v2 manager 1/5] api: ceph: add ceph/cfg path, deprecate ceph/config and ceph/configdb Aaron Lauterer
2023-03-20 8:35 ` Fabian Grünbichler
2023-03-16 13:48 ` [pve-devel] [PATCH v2 manager 2/5] ui: ceph config: use new ceph/cfg/ API endpoints Aaron Lauterer
2023-03-16 13:48 ` [pve-devel] [PATCH v2 manager 3/5] api: ceph: add endpoint to fetch config keys Aaron Lauterer
2023-03-16 15:47 ` [pve-devel] [PATCH v2 follow up " Aaron Lauterer
2023-03-16 13:48 ` [pve-devel] [PATCH v2 manager 4/5] fix #2515: ui: ceph pool create: use configured defaults for size and min_size Aaron Lauterer
2023-03-16 13:48 ` [pve-devel] [PATCH v2 manager 5/5] ui: ceph pool edit: rework with controller and formulas Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316134820.1193518-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox