public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] fix #4430: add UTC timezone as option to installer
Date: Thu, 16 Mar 2023 10:17:27 +0100	[thread overview]
Message-ID: <20230316091727.xfcrhernupazgpkh@maui.proxmox.com> (raw)
In-Reply-To: <8ea5bbf5-127e-1a8c-15d2-e092b0ddea7d@proxmox.com>

Thanks for the review!

On Wed, Mar 15, 2023 at 02:23:09PM +0100, Thomas Lamprecht wrote:
> [..]
>
> What I don't like as much that one has to set the country to the timezone,
> which is confusing UX and will be subtle to most.
>
> Better ways might be:
>
> - add an explicit "Use UTC" checkbox that grey's out the country/timezone
>   selection then. Disadvantage here would be taking up extra space and expanding
>   the user input amount, which goes a bit against our "as simple as possible"
>   approach for the installer
>
> - Add UTC always to the time-zone selection, independent of what country is
>   selected. This keeps the selection where it belongs, and allows to quickly
>   change to UTC without any typing/searching required (at least for most countries)
>
> From a gut feeling I'd go for the second option, but didn't checked out how the
> implementation would then look like.
From looking at the code while implementing this, the second option
shouldn't be that much of a hassle to implement I'd say (and probably
less than the first).

Sounds like the better option to me too. The first option could also
strike some users that this option is permament and cannot be changed
after installation, due to the grey'ing out and such, I guess.

I send a v2 soon with the second approach implemented, let's see how the
look & feel of that is.




      reply	other threads:[~2023-03-16  9:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 12:26 Christoph Heiss
2023-03-15 13:23 ` Thomas Lamprecht
2023-03-16  9:17   ` Christoph Heiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230316091727.xfcrhernupazgpkh@maui.proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal