* [pve-devel] [PATCH manager] ui: resource tree: correctly reinsert item when name changes
@ 2023-03-16 9:03 Dominik Csapak
2023-03-16 9:23 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2023-03-16 9:03 UTC (permalink / raw)
To: pve-devel
if the user has the tree sorted by name, we have to move the items
on a name change, otherwise they'll stay on the old position
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/tree/ResourceTree.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index 7d7900b59..54c6403d8 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -278,7 +278,8 @@ Ext.define('PVE.tree.ResourceTree', {
let groups = me.viewFilter.groups || [];
// explicitly check for node/template, as those are not always grouping attributes
- let moveCheckAttrs = groups.concat(['node', 'template']);
+ // also check for name for when the tree is sorted by name
+ let moveCheckAttrs = groups.concat(['node', 'template', 'name']);
let filterfn = me.viewFilter.filterfn;
let reselect = false; // for disappeared nodes
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: resource tree: correctly reinsert item when name changes
2023-03-16 9:03 [pve-devel] [PATCH manager] ui: resource tree: correctly reinsert item when name changes Dominik Csapak
@ 2023-03-16 9:23 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-03-16 9:23 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
Am 16/03/2023 um 10:03 schrieb Dominik Csapak:
> if the user has the tree sorted by name, we have to move the items
> on a name change, otherwise they'll stay on the old position
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/tree/ResourceTree.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-16 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 9:03 [pve-devel] [PATCH manager] ui: resource tree: correctly reinsert item when name changes Dominik Csapak
2023-03-16 9:23 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox