* [pve-devel] [PATCH manager] ui: don't show tags/lock column in pool member grid
@ 2023-03-15 15:30 Dominik Csapak
2023-03-15 17:18 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2023-03-15 15:30 UTC (permalink / raw)
To: pve-devel
we use a different api call where we currently don't have the tags or
lock, so don't add the columns there
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
we could also add these in the api call, or use the resource grid as
source for the grid (not needing an api call at all), but for now
this seems to be the fastest fix for it
www/manager6/grid/PoolMembers.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js
index 025288cc8..6acb622d6 100644
--- a/www/manager6/grid/PoolMembers.js
+++ b/www/manager6/grid/PoolMembers.js
@@ -160,7 +160,9 @@ Ext.define('PVE.grid.PoolMembers', {
},
});
- var coldef = PVE.data.ResourceStore.defaultColumns();
+ var coldef = PVE.data.ResourceStore.defaultColumns().filter((c) =>
+ c.dataIndex !== 'tags' && c.dataIndex !== 'lock',
+ );
var reload = function() {
store.load();
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: don't show tags/lock column in pool member grid
2023-03-15 15:30 [pve-devel] [PATCH manager] ui: don't show tags/lock column in pool member grid Dominik Csapak
@ 2023-03-15 17:18 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-03-15 17:18 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
Am 15/03/2023 um 16:30 schrieb Dominik Csapak:
> we use a different api call where we currently don't have the tags or
> lock, so don't add the columns there
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> we could also add these in the api call, or use the resource grid as
> source for the grid (not needing an api call at all), but for now
> this seems to be the fastest fix for it
>
> www/manager6/grid/PoolMembers.js | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-15 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-15 15:30 [pve-devel] [PATCH manager] ui: don't show tags/lock column in pool member grid Dominik Csapak
2023-03-15 17:18 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox