public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: don't show tags/lock column in pool member grid
Date: Wed, 15 Mar 2023 16:30:30 +0100	[thread overview]
Message-ID: <20230315153030.427647-1-d.csapak@proxmox.com> (raw)

we use a different api call where we currently don't have the tags or
lock, so don't add the columns there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
we could also add these in the api call, or use the resource grid as
source for the grid (not needing an api call at all), but for now
this seems to be the fastest fix for it

 www/manager6/grid/PoolMembers.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js
index 025288cc8..6acb622d6 100644
--- a/www/manager6/grid/PoolMembers.js
+++ b/www/manager6/grid/PoolMembers.js
@@ -160,7 +160,9 @@ Ext.define('PVE.grid.PoolMembers', {
 	    },
 	});
 
-	var coldef = PVE.data.ResourceStore.defaultColumns();
+	var coldef = PVE.data.ResourceStore.defaultColumns().filter((c) =>
+	    c.dataIndex !== 'tags' && c.dataIndex !== 'lock',
+	);
 
 	var reload = function() {
 	    store.load();
-- 
2.30.2





             reply	other threads:[~2023-03-15 15:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 15:30 Dominik Csapak [this message]
2023-03-15 17:18 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230315153030.427647-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal