public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH guest-common] vzdump: config: improve description of ionice setting
Date: Wed, 15 Mar 2023 14:24:25 +0100	[thread overview]
Message-ID: <20230315132425.119055-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230315132425.119055-1-f.ebner@proxmox.com>

The CFQ scheduler was removed with Linux 5.0 and ionice is now used
by the newer BFQ scheduler. Mention what the special value 8 does.
Also mention that for snapshot and suspend mode backups of VMs, the
setting only affects the compressor, because the kvm process is not a
child process of vzdump then and does not inherit the ionice priority.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/VZDump/Common.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
index 4b0e8e0..830c3e8 100644
--- a/src/PVE/VZDump/Common.pm
+++ b/src/PVE/VZDump/Common.pm
@@ -209,7 +209,10 @@ my $confdesc = {
     },
     ionice => {
 	type => 'integer',
-	description => "Set CFQ ionice priority.",
+	description => "Set IO priority when using the BFQ scheduler. For snapshot and suspend "
+	    ."mode backups of VMs, this only affects the compressor. A value of 8 means the idle "
+	    ."priority is used, otherwise the best-effort priority is used with the specified "
+	    ."value.",
 	optional => 1,
 	minimum => 0,
 	maximum => 8,
-- 
2.30.2





  parent reply	other threads:[~2023-03-15 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 13:24 [pve-devel] [PATCH manager] close #4513: ui: backup job: add performance tab Fiona Ebner
2023-03-15 13:24 ` [pve-devel] [PATCH docs] backup: update information about performance settings Fiona Ebner
2023-03-15 13:24 ` Fiona Ebner [this message]
2023-06-06 15:23 ` [pve-devel] [PATCH manager] close #4513: ui: backup job: add performance tab Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230315132425.119055-3-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal