From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 manager 3/3] ui: cert upload: fix private key field sending empty string
Date: Tue, 14 Mar 2023 16:08:39 +0100 [thread overview]
Message-ID: <20230314150839.248059-4-m.carrara@proxmox.com> (raw)
In-Reply-To: <20230314150839.248059-1-m.carrara@proxmox.com>
The private key's field is now excluded from the upload form's
JSON data if it's left empty.
Prior to this change, the form still used an empty string for the
private key's field, even if no key was provided by the user.
Because the key's field is marked as optional in the upload cert
API endpoint, JSONSchema validation would therefore fail.
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
---
www/manager6/node/Certificates.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/www/manager6/node/Certificates.js b/www/manager6/node/Certificates.js
index 29c17359..a086581c 100644
--- a/www/manager6/node/Certificates.js
+++ b/www/manager6/node/Certificates.js
@@ -171,6 +171,9 @@ Ext.define('PVE.node.CertUpload', {
onGetValues: function(values) {
values.restart = 1;
values.force = 1;
+ if (!values.key) {
+ delete values.key;
+ }
return values;
},
items: [
--
2.39.2
next prev parent reply other threads:[~2023-03-14 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 15:08 [pve-devel] [PATCH v3 manager 0/3] Fix SSL Certificate and Key Upload Issues Max Carrara
2023-03-14 15:08 ` [pve-devel] [PATCH v3 manager 1/3] fix #4552: certhelpers: check if custom cert and key match on change Max Carrara
2023-03-22 15:41 ` Max Carrara
2023-03-23 6:08 ` Thomas Lamprecht
2023-03-14 15:08 ` [pve-devel] [PATCH v3 manager 2/3] ui: cert upload: use inputpanel for certificate upload Max Carrara
2023-03-21 15:56 ` [pve-devel] applied: " Thomas Lamprecht
2023-03-14 15:08 ` Max Carrara [this message]
2023-03-21 15:57 ` [pve-devel] applied: [PATCH v3 manager 3/3] ui: cert upload: fix private key field sending empty string Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314150839.248059-4-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox