From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 manager 2/3] ui: cert upload: use inputpanel for certificate upload
Date: Tue, 14 Mar 2023 16:08:38 +0100 [thread overview]
Message-ID: <20230314150839.248059-3-m.carrara@proxmox.com> (raw)
In-Reply-To: <20230314150839.248059-1-m.carrara@proxmox.com>
This change replaces the the certificate upload form's items with
a single inputpanel widget. The components for the key and cert fields
are preserved as-is. Hardcoded values are now explicitly set in
`onGetValues` instead of using hidden widgets.
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
---
www/manager6/node/Certificates.js | 96 +++++++++++++++----------------
1 file changed, 45 insertions(+), 51 deletions(-)
diff --git a/www/manager6/node/Certificates.js b/www/manager6/node/Certificates.js
index 34013b44..29c17359 100644
--- a/www/manager6/node/Certificates.js
+++ b/www/manager6/node/Certificates.js
@@ -166,62 +166,56 @@ Ext.define('PVE.node.CertUpload', {
Ext.defer(() => window.location.reload(true), 10000); // reload after 10 seconds automatically
},
- items: [
- {
- fieldLabel: gettext('Private Key (Optional)'),
- labelAlign: 'top',
- emptyText: gettext('No change'),
- name: 'key',
- xtype: 'textarea',
+ items: {
+ xtype: 'inputpanel',
+ onGetValues: function(values) {
+ values.restart = 1;
+ values.force = 1;
+ return values;
},
- {
- xtype: 'filebutton',
- text: gettext('From File'),
- listeners: {
- change: function(btn, e, value) {
- let form = this.up('form');
- for (const file of e.event.target.files) {
- PVE.Utils.loadFile(file, res => form.down('field[name=key]').setValue(res));
- }
- btn.reset();
+ items: [
+ {
+ fieldLabel: gettext('Private Key (Optional)'),
+ labelAlign: 'top',
+ emptyText: gettext('No change'),
+ name: 'key',
+ xtype: 'textarea',
+ },
+ {
+ xtype: 'filebutton',
+ text: gettext('From File'),
+ listeners: {
+ change: function(btn, e, value) {
+ let form = this.up('form');
+ for (const file of e.event.target.files) {
+ PVE.Utils.loadFile(file, res => form.down('field[name=key]').setValue(res));
+ }
+ btn.reset();
+ },
},
},
- },
- {
- xtype: 'box',
- autoEl: 'hr',
- },
- {
- fieldLabel: gettext('Certificate Chain'),
- labelAlign: 'top',
- allowBlank: false,
- name: 'certificates',
- xtype: 'textarea',
- },
- {
- xtype: 'filebutton',
- text: gettext('From File'),
- listeners: {
- change: function(btn, e, value) {
- let form = this.up('form');
- for (const file of e.event.target.files) {
- PVE.Utils.loadFile(file, res => form.down('field[name=certificates]').setValue(res));
- }
- btn.reset();
+ {
+ fieldLabel: gettext('Certificate Chain'),
+ labelAlign: 'top',
+ allowBlank: false,
+ name: 'certificates',
+ xtype: 'textarea',
+ },
+ {
+ xtype: 'filebutton',
+ text: gettext('From File'),
+ listeners: {
+ change: function(btn, e, value) {
+ let form = this.up('form');
+ for (const file of e.event.target.files) {
+ PVE.Utils.loadFile(file, res => form.down('field[name=certificates]').setValue(res));
+ }
+ btn.reset();
+ },
},
},
- },
- {
- xtype: 'hidden',
- name: 'restart',
- value: '1',
- },
- {
- xtype: 'hidden',
- name: 'force',
- value: '1',
- },
- ],
+ ],
+ },
initComponent: function() {
let me = this;
--
2.39.2
next prev parent reply other threads:[~2023-03-14 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 15:08 [pve-devel] [PATCH v3 manager 0/3] Fix SSL Certificate and Key Upload Issues Max Carrara
2023-03-14 15:08 ` [pve-devel] [PATCH v3 manager 1/3] fix #4552: certhelpers: check if custom cert and key match on change Max Carrara
2023-03-22 15:41 ` Max Carrara
2023-03-23 6:08 ` Thomas Lamprecht
2023-03-14 15:08 ` Max Carrara [this message]
2023-03-21 15:56 ` [pve-devel] applied: [PATCH v3 manager 2/3] ui: cert upload: use inputpanel for certificate upload Thomas Lamprecht
2023-03-14 15:08 ` [pve-devel] [PATCH v3 manager 3/3] ui: cert upload: fix private key field sending empty string Max Carrara
2023-03-21 15:57 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314150839.248059-3-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox