From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: fix not opening 'bulk action' windows
Date: Tue, 14 Mar 2023 11:20:36 +0100 [thread overview]
Message-ID: <20230314102036.3340844-1-d.csapak@proxmox.com> (raw)
we previously removed the 'filters' property from the store, but this
has the effect that the filter array is only ever initialized when
we try to access them via the specified api of extjs
so instead of adding them manually to their array, use the 'addFilter'
method of extjs
also use 'getStore()' instead of directly accessing the store to be
consistent with the extjs api use
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/form/VMSelector.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index e9eb5dbaa..4c0bba137 100644
--- a/www/manager6/form/VMSelector.js
+++ b/www/manager6/form/VMSelector.js
@@ -211,7 +211,7 @@ Ext.define('PVE.form.VMSelector', {
me.getStore().load({ params: { type: 'vm' } });
if (me.nodename) {
- me.store.filters.add({
+ me.getStore().addFilter({
property: 'node',
exactMatch: true,
value: me.nodename,
@@ -230,7 +230,7 @@ Ext.define('PVE.form.VMSelector', {
break;
}
if (statusfilter !== '') {
- me.store.filters.add({
+ me.getStore().addFilter([{
property: 'template',
value: 0,
}, {
@@ -238,7 +238,7 @@ Ext.define('PVE.form.VMSelector', {
operator: 'in',
property: 'status',
value: [statusfilter],
- });
+ }]);
}
}
--
2.30.2
next reply other threads:[~2023-03-14 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 10:20 Dominik Csapak [this message]
2023-03-14 10:43 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314102036.3340844-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox