public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 6/6] ui: make tree settings button like regular buttons
Date: Fri, 10 Mar 2023 14:08:37 +0100	[thread overview]
Message-ID: <20230310130837.1188003-7-s.sterz@proxmox.com> (raw)
In-Reply-To: <20230310130837.1188003-1-s.sterz@proxmox.com>

the "proxmox-inline-button" class is redundant in the crisp theme as
it only sets the buttons text to black. we mainly use that class for
"help" buttons. this is useful in the dark theme, because we want help
buttons to stand out a bit so (possibly confused) users are drawn to
them more easily. removing the class here doesn't change anything for
"crisp", but makes the dark theme appear more consistent. also fixes
up an unnecessary space.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 www/manager6/Workspace.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 78ab37b6..8cee3638 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -469,8 +469,8 @@ Ext.define('PVE.StdWorkspace', {
 				selview,
 				{
 				    xtype: 'button',
-				    cls: 'x-btn-default-toolbar-small proxmox-inline-button',
-				    iconCls: 'fa fa-fw fa-gear x-btn-icon-el-default-toolbar-small ',
+				    cls: 'x-btn-default-toolbar-small',
+				    iconCls: 'fa fa-fw fa-gear x-btn-icon-el-default-toolbar-small',
 				    handler: () => {
 					Ext.create('PVE.window.TreeSettingsEdit', {
 					    autoShow: true,
-- 
2.30.2





  parent reply	other threads:[~2023-03-10 13:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 13:08 [pve-devel] [PATCH widget-toolkit 0/6] Proxmox Dark Theme Fix-ups Round 1 Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 1/6] dark-theme: fix summary row background Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 2/6] dark-theme: make windows stand out more against the background mask Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 3/6] dark-theme: re-work buttons colors to appear dimmer Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 4/6] dark-theme: remove thicker borders around content Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 5/6] dark-theme: visually remove the border around the pve resource tree Stefan Sterz
2023-03-10 13:08 ` Stefan Sterz [this message]
2023-03-11 16:54 ` [pve-devel] applied-series: [PATCH widget-toolkit 0/6] Proxmox Dark Theme Fix-ups Round 1 Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310130837.1188003-7-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal