public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 3/6] dark-theme: re-work buttons colors to appear dimmer
Date: Fri, 10 Mar 2023 14:08:34 +0100	[thread overview]
Message-ID: <20230310130837.1188003-4-s.sterz@proxmox.com> (raw)
In-Reply-To: <20230310130837.1188003-1-s.sterz@proxmox.com>

this dims buttons further by removing pure white text color and
adjusting backgrounds and border accordingly. it also keeps the help
buttons brighter than other buttons to draw (possibly confused) users
to them.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/abstracts/_variables.scss | 10 +++++-----
 src/proxmox-dark/scss/extjs/form/_button.scss   |  1 +
 src/proxmox-dark/scss/proxmox/_helpbutton.scss  |  1 +
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/proxmox-dark/scss/abstracts/_variables.scss b/src/proxmox-dark/scss/abstracts/_variables.scss
index 96581df..cf61ad2 100644
--- a/src/proxmox-dark/scss/abstracts/_variables.scss
+++ b/src/proxmox-dark/scss/abstracts/_variables.scss
@@ -28,14 +28,14 @@ $background-invalid: hsl(360deg, 60%, 30%);
 $background-warning: hsl(40deg, 100%, 30%);
 
 // Buttons
-$neutral-button-color: hsl(0deg, 0%, 35%);
-$neutral-button-color-alt: hsl(0deg, 0%, 55%);
-$neutral-button-text-color: hsl(0deg, 0%, 100%);
+$neutral-button-color: hsl(0deg, 0%, 25%);
+$neutral-button-color-alt: hsl(0deg, 0%, 35%);
+$neutral-button-text-color: hsl(0deg, 0%, 95%);
 $neutral-button-icon-color: $neutral-button-text-color;
 
 // Help Buttons
-$help-button-color: hsl(0deg, 0%, 70%);
-$help-button-color-alt: hsl(0deg, 0%, 60%);
+$help-button-color: hsl(0deg, 0%, 65%);
+$help-button-color-alt: hsl(0deg, 0%, 55%);
 $help-button-text-color: hsl(0deg, 0%, 10%);
 $help-button-icon-color: $help-button-text-color;
 
diff --git a/src/proxmox-dark/scss/extjs/form/_button.scss b/src/proxmox-dark/scss/extjs/form/_button.scss
index 0aa1475..bf02135 100644
--- a/src/proxmox-dark/scss/extjs/form/_button.scss
+++ b/src/proxmox-dark/scss/extjs/form/_button.scss
@@ -35,6 +35,7 @@
   &.x-btn-over,
   .x-keyboard-mode &.x-btn-focus {
     background-color: $neutral-button-color-alt;
+    border-color: $neutral-button-color-alt;
 
     // the little arrow in certain toolbar buttons with dropdowns
     .x-btn-wrap-default-toolbar-small.x-btn-arrow-right::after,
diff --git a/src/proxmox-dark/scss/proxmox/_helpbutton.scss b/src/proxmox-dark/scss/proxmox/_helpbutton.scss
index aad92e2..817d6a1 100644
--- a/src/proxmox-dark/scss/proxmox/_helpbutton.scss
+++ b/src/proxmox-dark/scss/proxmox/_helpbutton.scss
@@ -1,6 +1,7 @@
 // help buttons
 .proxmox-inline-button {
   background-color: $help-button-color;
+  border-color: $help-button-color-alt;
   color: $help-button-text-color;
 
   &.x-btn-over,
-- 
2.30.2





  parent reply	other threads:[~2023-03-10 13:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 13:08 [pve-devel] [PATCH widget-toolkit 0/6] Proxmox Dark Theme Fix-ups Round 1 Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 1/6] dark-theme: fix summary row background Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 2/6] dark-theme: make windows stand out more against the background mask Stefan Sterz
2023-03-10 13:08 ` Stefan Sterz [this message]
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 4/6] dark-theme: remove thicker borders around content Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH widget-toolkit 5/6] dark-theme: visually remove the border around the pve resource tree Stefan Sterz
2023-03-10 13:08 ` [pve-devel] [PATCH manager 6/6] ui: make tree settings button like regular buttons Stefan Sterz
2023-03-11 16:54 ` [pve-devel] applied-series: [PATCH widget-toolkit 0/6] Proxmox Dark Theme Fix-ups Round 1 Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310130837.1188003-4-s.sterz@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal