[pve-devel] [PATCH common] certificate: actually print openssl errors

[pve-devel] [PATCH common] certificate: actually print openssl errors

[Fabian Grünbichler]

print_errs (which is also called internally by die_now) will only 'warn' the
collected error stack if the log level is set to tracing. otherwise, it will
just return the error message(s) corresponding to the error stack as string.

while they are not always the most user-friendly ones, they do provide
additional context that might help to find out what is actually causing a
particular failure. both helpers here actually provide a meaninful user
friendly context (via $msg) as final line.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---

Notes:
    noticed while testing Max' key check series

 src/PVE/Certificate.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm
index 73091ff..3322557 100644
--- a/src/PVE/Certificate.pm
+++ b/src/PVE/Certificate.pm
@@ -181,12 +181,13 @@ sub der_to_pem {
 
 my $ssl_die = sub {
     my ($msg) = @_;
+    warn Net::SSLeay::print_errs();
     Net::SSLeay::die_now($msg);
 };
 
 my $ssl_warn = sub {
     my ($msg) = @_;
-    Net::SSLeay::print_errs();
+    warn Net::SSLeay::print_errs();
     warn $msg if $msg;
 };
 
-- 
2.30.2

[pve-devel] applied: [PATCH common] certificate: actually print openssl errors

[Thomas Lamprecht]

Am 07/03/2023 um 11:50 schrieb Fabian Grünbichler:
> print_errs (which is also called internally by die_now) will only 'warn' the
> collected error stack if the log level is set to tracing. otherwise, it will
> just return the error message(s) corresponding to the error stack as string.
> 
> while they are not always the most user-friendly ones, they do provide
> additional context that might help to find out what is actually causing a
> particular failure. both helpers here actually provide a meaninful user
> friendly context (via $msg) as final line.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> 
> Notes:
>     noticed while testing Max' key check series
> 
>  src/PVE/Certificate.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, with merge conflict resolved as I dropped the unused warn helper
and made the error one a local sub instead of a $code ref in-between, thanks!